Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the directory creation and ownership setting code before the file read operation to prevent the file read error.
antonmedv
approved these changes
May 21, 2024
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Jun 1, 2024
* origin/master: (40 commits) Improve the configuration options console output in provision:configure (deployphp#3840) Update Craft CMS deploy recipe (deployphp#3839) [automatic] Update docs with bin/docgen Update provision.php Feature/UI enhancements (deployphp#3835) Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website (deployphp#3837) [automatic] Update docs with bin/docgen docs(recipe/shopware): add code syntax highlighting (deployphp#3834) [automatic] Update docs with bin/docgen docs(recipe/magento2): fix typo in conccurent (deployphp#3830) [automatic] Update docs with bin/docgen magento2 theme processing fix for 3786 (deployphp#3818) use md5 of task name for section id in gitlab ci (deployphp#3817) [automatic] Update docs with bin/docgen Magento 2: Changed upgrading database (deployphp#3812) [automatic] Update docs with bin/docgen Shopware: Added `deploy:update_code` (deployphp#3816) [automatic] Update docs with bin/docgen Update nodejs to LTS version (deployphp#3815) Update LICENSE ...
|
I'm still getting this error with symfony even on 7.4, had to downgrade to "deployer/deployer": "7.3.3", |
Hi, this is because this PR isn't in a release yet. @antonmedv Any chance to make a minor release with the bugfix? Thanks |
|
Will release. |
|
Any news on this release? Also having to use 7.3.3 in the meantime. |
|
There should be and var to allow to specify the caddyfile to use, if var is not set then use the default file, I was using a custom caddyfile and this update was a problem for me. |
|
This is a good idea. We can create a dir with all needed configuration go there. Like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: Fixes 2 bugs. Related issue: #3836
New feature: No features were added in this issue.BC breaks: No backward compatibility breaks in this release.Tests added: No new tests were added in this release.Docs added: No new documentation was added in this release.