Feature/2423 shopware order modules #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong order - add dependency for polyfill (to use str_ends_with) - marcj/topsort (for sorting the shopware modules)
…wrong order - get the plugin list - read the composer names and dependencies from composer.lock - order by dependencies - use sorted list for activation and migration
…wrong order Update changelog
…wrong order do not update doc, but remove require autoload.php
Schrank
force-pushed
the
feature/2423-shopware-order-modules
branch
from
06c28fd
to
363c13f
Compare
|
I'm sooo happy... Works - once you pushed the updated composer.lock :D |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reads the dependency infos of shopware modules from composer.lock and sorts the modules according to the
requiredependencies before activating/migration them.@peterjaap please have a look for the content
@antonmedv I See no way around marcj/topsort, but for PHP8 I only need
str_ends_with, so in theory we could implement this method on our own and remove the dependency on polyfill80.