Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check (shared) file exists #2393

Merged

Conversation

dsmink
Copy link
Contributor

@dsmink dsmink commented Jan 28, 2021

Doing a check if the shared file already exists.
A touch could result in a 'Permission denied' causing the deploy to stop.

Doing a check if the shared file already exists.
A touch could result in a 'Permission denied' causing the deploy to stop.
@antonmedv
Copy link
Member

I think in this case deploy should stop?

@dsmink
Copy link
Contributor Author

dsmink commented Jan 28, 2021

@antonmedv
Why? The shared file does not have to be writable by the person (or its group) performing the deploy is it? This is the case in our situation. Also, touching a file that already exists only changes the modification time. That is where our deploy fails now.

@antonmedv
Copy link
Member

Got it.

@Schrank
Copy link
Contributor

Schrank commented Feb 22, 2021

@antonmedv do you want/need anything to merge this? A test or something?

@Schrank Schrank merged commit 27c7b61 into deployphp:master Mar 5, 2021
@antonmedv
Copy link
Member

Nice! Thanks for pr and merge hustle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants