prevent warning when pcntl_fork() is on disable_functions php.ini bla… #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
reviewed
Dec 27, 2017
| @@ -17,7 +17,7 @@ class Reporter | |||
| public static function report(array $stats) | |||
| { | |||
| $pid = null; | |||
| if (extension_loaded('pcntl')) { | |||
There was a problem hiding this comment.
Maybe it's better to use function_exists? If it available?
There was a problem hiding this comment.
function_exists also works. I feel it is less expressive, but nevertheless changed it.
|
Friendly ping @antonmedv |
|
Fixed build |
antonmedv
pushed a commit
that referenced
this pull request
Apr 18, 2018
#1476) * prevent warning when pcntl_fork() is on disable_functions php.ini blacklist * Update CHANGELOG.md * Update Reporter.php * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cklist
pcntl_forkis blacklisted per default on ubuntu lts boxes. make sure deployer doesnt emit a warning in this case.Without this fix you get