Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use try/finally to make sure working-path restore on Exceptions #1463

Merged
merged 5 commits into from
Dec 20, 2017
Merged

use try/finally to make sure working-path restore on Exceptions #1463

merged 5 commits into from
Dec 20, 2017

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 20, 2017

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

fix within() to also restore the working-path when the given callback throws a Exception

@antonmedv antonmedv merged commit b8c81fa into deployphp:master Dec 20, 2017
@antonmedv
Copy link
Member

Nice!

@staabm staabm deleted the patch-2 branch December 20, 2017 12:36
antonmedv pushed a commit that referenced this pull request Apr 18, 2018
@staabm @antonmedv
use try/finally to make sure working-path restore on Exceptions (#1463)
c49936b 
* use try/finally to make sure working-path restore on Exceptions

* Update functions.php

* Update CHANGELOG.md

* Update CHANGELOG.md

* fixed CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @antonmedv