Per user persistent storage #1269
Conversation
…e same instance(s) if two or more users are deploying a project on the same environment, the generated hosts files are overwritten or worse, the deploy will fail due to file permissions Make the persistent storage folder configurable or use the system tmp as default if not possible
when the persistent storage it's located in the system tmp
when the persistent storage it's located in the system tmp. Dropped the uniqueid.
src/Host/Storage.php
Outdated
| // use the system temporary folder and the current pid as default | ||
| // persistent storage in case we can't use the configured value | ||
| // or we can't create the default location | ||
| $tmp = sys_get_temp_dir() . '/' . posix_getpid(); |
There was a problem hiding this comment.
This extension is not available on Windows platforms.
http://php.net/manual/en/intro.posix.php
There was a problem hiding this comment.
For non posix compatible i'm going to use getmypid.
src/Host/Storage.php
Outdated
| * @return string | ||
| * @throws Exception | ||
| */ | ||
| private static function _getPersistentStorageLocation() { |
There was a problem hiding this comment.
Rename _getPersistentStorageLocation to getPersistentStorageLocation and move this method to end of class.
src/Host/Storage.php
Outdated
| $tmp = sys_get_temp_dir() . '/' . posix_getpid(); | ||
|
|
||
| // get the location for the deployer configuration | ||
| $deployerConfig = $config->has('deployer_config') ? $config->get('deployer_config') : null; |
There was a problem hiding this comment.
It's over this PR, I think such functionality should done in separate PR.
Anyway I don't see way it's needed. Please remove everything related to deployer_config.
src/Host/Storage.php
Outdated
|
|
||
| // use the home dir of the current user | ||
| // and the repository name | ||
| $userInfo = posix_getpwuid(posix_getuid()); |
There was a problem hiding this comment.
Same here, what about windows?
There was a problem hiding this comment.
For non posix compatible i'm going to use getenv.
getenv('HOMEDRIVE'), getenv('HOMEPATH') are available on windows 8+
getenv('HOME') for *nix
It's Windows 8+ enough?
src/Host/Storage.php
Outdated
| } | ||
|
|
||
| // we now have the repository name | ||
| $repository = str_replace('/', '_', substr($configRepository, (strrpos($configRepository, ':') + 1))); |
There was a problem hiding this comment.
Long story short: i have five webapps on the same instances (my staging). If i deploy two apps at the same time (using two terminals for example) the second one i launch will overwrite the content of the .dep files so, the first deployer will start running tasks in the locations set by the second one and everything ends up in a mess.
The .dep files should be stored per webapp so, the easiest way was to use the repository to generate a separate folder name.
There was a problem hiding this comment.
I think it's easier to create rundom files instead.
There was a problem hiding this comment.
Easier yes... but then you will need an internal task to clean up temporary files older than N days or something simmilar.
This way it's cleaner... i would say :)
There was a problem hiding this comment.
But tmp cleaned by system itself
Removed the option to used a configuration variable to set the persistent storage location.
|
Windows 8+ and non posix systems compatibility, added alternatives to the posix_* calls:
Method _getPersistentStorageLocation renamed to getPersistentStorageLocation and moved at then end. Dropped the option to have a configurable path for the persistent storage folder. |
src/Host/Storage.php
Outdated
| } | ||
|
|
||
| // we now have the repository name | ||
| $repository = str_replace('/', '_', substr($configRepository, (strrpos($configRepository, ':') + 1))); |
There was a problem hiding this comment.
I think it's easier to create rundom files instead.
|
Removed everything and replaced it with randomly generate file names in system tmp. |
In a multi user environment where multiple projects are located on the same instance(s)
if two or more users are deploying a project on the same environment, the generated hosts files
in the system tmp folder are overwritten or worse, the deploy will fail due to file permissions.
Make the persistent storage folder configurable or use the system tmp as default if not possible.