Verify that writable directories exist #1000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yisraeldov I guess that requires a test. What do you mean by |
pluseg
suggested changes
Feb 21, 2017
| @@ -18,6 +18,9 @@ | |||
| return; | |||
| } | |||
|
|
|||
| //verify that directories exist | |||
| run("mkdir -vp $dirs"); | |||
There was a problem hiding this comment.
@yisraeldov
It doesn't work. Need to move it under cd('{{release_path}}');.
Also please add test in test/recipe/CommonTest.php:testWriteable(). It requires just adding non-existed folder in writable_dirs and checking existence after deploy:writable.
Do you have time for that? If not then I'll do it.
|
Not sure when I'll have a chance to do it...
…On Tue, Feb 21, 2017 at 11:29 AM Maxim Kuznetsov ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In recipe/deploy/writable.php
<#1000 (comment)>:
> @@ -18,6 +18,9 @@
return;
}
+ //verify that directories exist
+ run("mkdir -vp $dirs");
@yisraeldov <https://github.com/yisraeldov>
It doesn't work. Need to move it under cd('{{release_path}}');.
Also please add test in test/recipe/CommonTest.php:testWriteable(). It
requires just adding non-existed folder in writable_dirs and checking
existence after deploy:writable.
Do you have time for that? If not then I'll do it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1000 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIb6xm876qe-R4DFhSu1miejOv0gD5qks5req56gaJpZM4L4R-X>
.
|
|
@yisraeldov it's not a problem, thanks for response! I will create a patch. |
|
New PR: #1049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a directory in the
$writableslist that is not in the git repository, then attempting to set that directories permissions will cause the deploy to fail.