Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#16 #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue#16 #26

wants to merge 6 commits into from

Conversation

Kapnobatai3434
Copy link
Contributor

Fix eslint errors #16

Description

Eslint error "prefer-const" was fixed with the previous commit which fixed error "one-var".
Eslint error "no-use-before-define" required to completely reorganize start.js.
Everything was done according to the code style of the project.

Motivation and Context

It fixes eslint errors.

#16

How Has This Been Tested?

npm run test

Jest

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

Copy link
Member

@moorthi07 moorthi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice to have it cleaned up.

@andreialecu
Copy link
Contributor

Looks like there's a conflict here. Mind resolving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants