fix: when scanning non-existant virtual modules, ensure that undefine…

…d failedLookupLocations won't break
dependents · Apr 18, 2024 · bcafb0d · bcafb0d
1 parent 054c8d3
commit bcafb0d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -260,7 +260,7 @@ function tsLookup({ dependency, filename, directory, webpackConfig, tsConfig, ts
     }
   } else {
     const suffix = '.d.ts';
-    const lookUpLocations = namedModule.failedLookupLocations
+    const lookUpLocations = (namedModule.failedLookupLocations || [])
       .filter(string => string.endsWith(suffix))
       .map(string => string.substr(0, string.length - suffix.length));
 

diff --git a/test/test.js b/test/test.js
@@ -398,6 +398,16 @@ describe('filing-cabinet', () => {
             assert.equal(result, expected);
           });
 
+          it('finds imports of non-existent typescript imports', () => {
+            const filename = path.join(directory, '/index.ts');
+            const result = cabinet({
+              partial: 'virtual:test-virtual',
+              filename,
+              directory
+            });
+            assert.equal(result, '');
+          });
+
           it('finds imports of non-typescript files using custom import paths', () => {
             const filename = path.join(directory, '/index.ts');
             const result = cabinet({