Support Windows runners

[rossbeehler]

Any chance we can get this to support Windows GitHub Actions runners? Since you're using a docker container action, I'm pretty sure it will only work on Linux (see https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action). The Azure Pipelines equivalent interacts with the dependency-check tool directly within the agent itself (downloading it, ensuring Java is present and setup well, etc.), which allows it to be used on both Windows and Linux.

If I'm mistaken and this should work, just let me know and I'll give it a shot. Otherwise, if I'm correct, you might want to update the readme.md to list this as a limitation.

[javixeneize]

Hi

I think it should work. Can you give it a try?

https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/linux-containers

[rossbeehler]

Yeah, i get this error:

Run dependency-check/Dependency-Check_Action@main
  with:
    project: test
    path: .
    format: HTML
    args: --failOnCVSS 7 --enableRetired
Error: Container action is only supported on Linux

when running this workflow:

name: test-dependency-check

on:
  workflow_dispatch:

jobs:
  test-dependency-check:
    runs-on: windows-latest
    steps:
      - uses: actions/checkout@v2

      - name: Setup msbuild.exe
        uses: microsoft/[email protected]

      - name: NuGet restore
        run: nuget restore test.sln

      - name: Depcheck
        uses: dependency-check/Dependency-Check_Action@main
        id: Depcheck
        with:
          project: 'test'
          path: '.'
          format: 'HTML'    
          args: >
            --failOnCVSS 7
            --enableRetired

[javixeneize]

Looks like github doesnt support this - actions/runner#904

…

On Wed, Mar 9, 2022 at 9:32 PM rossbeehler ***@***.***> wrote: Yeah, i get this error: Run ***@***.*** with: project: test path: . format: HTML args: --failOnCVSS 7 --enableRetired Error: Container action is only supported on Linux when running this workflow: name: test-dependency-check on: workflow_dispatch: jobs: test-dependency-check: runs-on: windows-latest steps: - uses: ***@***.*** - name: Setup msbuild.exe uses: ***@***.*** - name: NuGet restore run: nuget restore test.sln - name: Depcheck uses: ***@***.*** id: Depcheck with: project: 'test' path: '.' format: 'HTML' args: > --failOnCVSS 7 --enableRetired — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBLTZXMVUVEVJZ2GVALEX3U7EKIJANCNFSM5QKHFGJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[rossbeehler]

An alternative is to not use docker at all, but do what is found here: https://github.com/dependency-check/azuredevops/blob/main/src/Tasks/dependency-check-build-task/dependency-check-build-task.ts

This is a heavy lift, and you may choose not to rewrite this action to match, but maybe the compromise is to modify the readme.md to at least note the limitation. Feel free to also use this issue to gauge interest in this functionality as well by leaving it open, etc.

[javixeneize]

Feel free to do a pr with the changes, it would be good El El mié, 9 mar 2022 a las 21:41, rossbeehler ***@***.***> escribió:

…

An alternative is to not use docker at all, but do what is found here: https://github.com/dependency-check/azuredevops/blob/main/src/Tasks/dependency-check-build-task/dependency-check-build-task.ts This is a heavy lift, and you may choose not to rewrite this action to match, but maybe the compromise is to modify the readme.md to at least note the limitation. Feel free to also use this issue to gauge interest in this functionality as well by leaving it open, etc. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBLTZU3TFYFSI4CTECTQY3U7ELIFANCNFSM5QKHFGJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>