-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ls-remote command and git+ssh protocol #16
Conversation
db50c3e
to
7a908bd
Compare
7a908bd
to
8842e5e
Compare
Co-authored-by: Jeff Widman <[email protected]>
Did we try this against dependabot/dependabot-core#7258? I'm afraid it's now going to start "succeeding" now but generating incorrect PRs since it will use "private repo syntax" for the dependency using ssh. |
@deivid-rodriguez I haven't cut a release of git-shim and bumped core yet, so all is good still. I'll repro it and see if this changes anything. Thanks for the heads up! |
Ok, great! I mean it would not be the end of the world, but generally I consider a completely broken update better than a successful update with the wrong PR contents. I did try changing git-shim last week to do this, but I think I didn't build the binary properly or I didn't put it at the right path, because it seemed to have no effect I did change our |
Just tried locally on main with the updated shim, it still fails, but on a
No amount of argument rewriting can fix that since the URL isn't an argument. Looks like the upstream fix is definitely the way to go. |
Well, that's good because this patch won't make the behaviour any worse, just make it fail a bit later. Thanks for verifying this! |
The integration test uses a Docker container that doesn't have
ssh
installed so the commands would fail normally. This is a simpler setup than building a Docker network and achieves the same result. If thedocker build
fails then the test fails!