Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize folder names #8698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Normalize folder names #8698

wants to merge 1 commit into from

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jan 4, 2024 •
edited
Loading

I find it confusing that we use different naming in source code ("updater/") and in the updater image file structure ("dependabot-updater/").

This PR tries to normalize that.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner January 4, 2024 17:55
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages labels Jan 4, 2024
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/normalize-folders branch 3 times, most recently from 3f36b38 to bd77b03 Compare January 4, 2024 19:04
@deivid-rodriguez deivid-rodriguez mentioned this pull request Jan 4, 2024
Open
@jakecoffman
Copy link
Member

We'll have to change these in all the runners: https://github.com/dependabot/cli/blob/f50317a4a56527afc8f575f19f39e78e0c9c2303/internal/infra/updater.go#L33-L35

I think they have to be absolute paths.

I wonder if dropping a symbolic link in the Dockerfile from dependabot-updater to updater would ease the transition?

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Jan 4, 2024 •
edited
Loading

Yeah, correct!

I added some code for backwards compatibility but honestly a symlink in the Dockerfile sounds like a better and safer approach. I'll update this PR!

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/normalize-folders branch from bd77b03 to 8a6ba4e Compare January 5, 2024 17:48
jakecoffman
jakecoffman previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those PRs I'd make sure to use it with staging before going to prod 😄

@deivid-rodriguez
Copy link
Contributor Author

Haha, yes, I was planning to do that. It's an all works or nothing works PR 😅.

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/normalize-folders branch 2 times, most recently from 0f38d2a to d3b6b05 Compare January 10, 2024 11:12
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/normalize-folders branch from d3b6b05 to a28249a Compare January 10, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deivid-rodriguez @jakecoffman