Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Python: skip flaky poetry spec with issue comment" #6191

Merged
merged 3 commits into from
Nov 23, 2022

Commits on Nov 22, 2022

  1. Revert "Python: skip flaky poetry spec with issue comment"

    The associated ticket on Poetry
    (python-poetry/poetry#3010) was closed because
    the underlying triggers were mostly resolved in `poetry` `1.2` using the
    new installer. In particular, see
    python-poetry/poetry#3010 (comment).
    
    We flipped to the new installer in
    #5838, so this skip
    should no longer be necessary.
    
    This reverts commit ceb5700.
    
    Additionally, this flips the fixture from a Python 2 to a Python 3
    fixture. We dropped support for Python 2 a while ago, but didn't notice
    this test needed updating because it was skipped.
    
    Another test still needs a python 2 fixture to ensure that lockfiles
    still pinned to python 2 throw the correct exception.
    
    So copied the existing fixture, updated it to specify a python 3
    version, and then regenerated the lockfile using:
    ```
    PYENV_VERSION=3.10.7 pyenv exec poetry lock --no-update
    ```
    jeffwidman committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6d71200 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Fixing poetry major.minor compatibility

    Adding a test to ensure we don't update the pyproject.toml with a new python version, but temporarily we expand the range to allow the update to proceed.
    pavera committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    29c23e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf96b6a View commit details
    Browse the repository at this point in the history