Allow Actions to be fetched from non-GitHub source #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we realized that we lacked the ability to fetch Actions from non-GitHub.com sources. With this change, we're now able to fetch Actions from GitHub Enterprise Server instances.
jurre
reviewed
Aug 3, 2022
| @@ -55,7 +55,7 @@ def workfile_file_dependencies(file) | |||
| def build_github_dependency(file, string) | |||
| details = string.match(GITHUB_REPO_REFERENCE).named_captures | |||
| name = "#{details.fetch('owner')}/#{details.fetch('repo')}" | |||
| url = "https://github.com/#{name}" | |||
| url = "https://#{source.hostname}/#{name}" | |||
There was a problem hiding this comment.
I was wondering if we should also grab the scheme from the source, but looks like it isn't available, and people should really use ssl so 🤷
jurre
approved these changes
Aug 3, 2022
landongrindheim
deleted the
enable-non-github-dotcom-sources-for-actions
branch
Merged
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we realized that we lacked the ability to fetch Actions
from non-GitHub.com sources. With this change, we're now able to fetch
Actions from GitHub Enterprise Server instances.