Terraform: fix module updates with a lockfile #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
commented
Jun 23, 2021
| @@ -691,21 +691,6 @@ module "consul" { | |||
| provider "registry.terraform.io/hashicorp/aws" { | |||
| version = "3.45.0" | |||
| constraints = ">= 3.37.0, < 3.46.0" | |||
| hashes = [ | |||
| "h1:LKU/xfna87/p+hl5yTTW3dvOqWJp5JEM+Dt3nnvSDvA=", | |||
There was a problem hiding this comment.
This expectation was flaking on my machine as the hash is changing
feelepxyz
force-pushed
the
feelepxyz/handle-modules-with-lockfiles
branch
from
47756ad to
318488d
Compare
This is the other side of #3968 This fixes module updates when there's a lockfile present. Modules are not included in the lockfile so adding a guard to only attempt lockfile updates for providers. Fixed some test setup to match what the parsed files would look like.
feelepxyz
force-pushed
the
feelepxyz/handle-modules-with-lockfiles
branch
from
318488d to
44a5b08
Compare
jurre
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other side of #3968
This fixes module updates when there's a lockfile present. Modules are
not included in the lockfile so adding a guard to only attempt lockfile
updates for providers.
Fixed some test setup to match what the parsed files would look like.