Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bundler 2.2.11 and update gem #3271

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Install bundler 2.2.11 and update gem #3271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,13 @@ RUN apt-get update \

# Install Ruby 2.6.6, update RubyGems, and install Bundler
ENV BUNDLE_SILENCE_ROOT_WARNING=1
RUN apt-get install -y software-properties-common \
RUN apt-get update && apt-get install -y software-properties-common \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step failed without this initial update complaining that software-properties-common wasn't installed, not sure why

&& apt-add-repository ppa:brightbox/ruby-ng \
&& apt-get update \
&& apt-get install -y ruby2.6 ruby2.6-dev \
&& gem update --system 3.0.3 \
&& gem install bundler -v 1.17.3 --no-document
&& gem update --system 3.2.14 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have dug through changes on rubygems for the version, requirement and specifications class. There are some changes to sorting of the requirements class: https://github.com/rubygems/rubygems/pull/2652/files

Test suite looks green so seems we don't rely on this here. I know we rely on it somewhat in api which prevented us from upgrading to ruby 2.7 but don't think this change will affect api as gem is installed from the ruby2.7 docker image there.

&& gem install bundler -v 1.17.3 --no-document \
&& gem install bundler -v 2.2.11 --no-document


### PYTHON
Expand Down