chore: mount bundler/helpers in docker dev container

[xlgmokha]

Why is this needed?

When mounting the development environment via ./bin/docker-dev-shell
the bundler/helpers folder is not mounted to the $CODE_DIR so
the line native_spec_helper that attempts to load one of the files
in that directory will fail.

How was this fixed?

I add a volume mount point to include the bundler/helpers directory
in the $CODE_DIR.

Before:

[dependabot-core-dev] ~/dependabot-core $ cd bundler && bundle exec rspec

An error occurred while loading ./spec/native_helpers/functions/conflicting_dependency_resolver_spec.rb.
Hint: Install the `did_you_mean` gem in order to provide suggestions for similarly named files.
Failure/Error: require "definition_ruby_version_patch"

LoadError:
  cannot load such file -- definition_ruby_version_patch
# ./spec/native_spec_helper.rb:9:in `require'
# ./spec/native_spec_helper.rb:9:in `<top (required)>'
# ./spec/native_helpers/functions/conflicting_dependency_resolver_spec.rb:3:in `require'
# ./spec/native_helpers/functions/conflicting_dependency_resolver_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/native_helpers/functions/dependency_source_spec.rb.
Hint: Install the `did_you_mean` gem in order to provide suggestions for similarly named files.
Failure/Error: require "definition_ruby_version_patch"

LoadError:
  cannot load such file -- definition_ruby_version_patch
# ./spec/native_spec_helper.rb:9:in `require'
# ./spec/native_spec_helper.rb:9:in `<top (required)>'
# ./spec/native_helpers/functions/dependency_source_spec.rb:3:in `require'
# ./spec/native_helpers/functions/dependency_source_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/native_helpers/functions/file_parser_spec.rb.
Hint: Install the `did_you_mean` gem in order to provide suggestions for similarly named files.
Failure/Error: require "definition_ruby_version_patch"

LoadError:
  cannot load such file -- definition_ruby_version_patch
# ./spec/native_spec_helper.rb:9:in `require'
# ./spec/native_spec_helper.rb:9:in `<top (required)>'
# ./spec/native_helpers/functions/file_parser_spec.rb:3:in `require'
# ./spec/native_helpers/functions/file_parser_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/native_helpers/functions/version_resolver_spec.rb.
Hint: Install the `did_you_mean` gem in order to provide suggestions for similarly named files.
Failure/Error: require "definition_ruby_version_patch"

LoadError:
  cannot load such file -- definition_ruby_version_patch
# ./spec/native_spec_helper.rb:9:in `require'
# ./spec/native_spec_helper.rb:9:in `<top (required)>'
# ./spec/native_helpers/functions/version_resolver_spec.rb:3:in `require'
# ./spec/native_helpers/functions/version_resolver_spec.rb:3:in `<top (required)>'


Finished in 0.00005 seconds (files took 1.16 seconds to load)
0 examples, 0 failures, 4 errors occurred outside of examples

Coverage report generated for RSpec to /home/dependabot/dependabot-core/bundler/coverage. 735 / 2216 LOC (33.17%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected

After:

[dependabot-core-dev] ~/dependabot-core/bundler $ bundle exec rspec

Randomized with seed 23468
......................................................................

[thepwagner]

Question: is this /opt/bundler/helpers mount actually used? It seems eerily close to the $CODE_DIR/bundler/helpers mount we're adding.

I have no idea, just wondering if this was how this was supposed to work, and could be cruft after this fix to how it actually works. I would not be surprised if both are needed for difference cases (e.g. rspec vs bin/dry-run.rb).

This entire comment is idle curiosity and safe to ignore.

[feelepxyz]

I think both are needed for now as rspec loads stuff from the code dir, but might only be needed for native helper specs. We copy native helpers to /opt/bundler and run them from there when running dry-runs/tests.

We might be able to simplify this with the bundler 2 work, planning to move the native helpers specs into the helper folder and run rspec from there.

[feelepxyz]

Thanks for fixing this 💯