Fix flaky npm 6 peer dependency test #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this spec has become flaky recently, not clear why but seems to have fixed it by making the expectation compare the dependency hash instead of the instance. Also removed the alias on `npm6` as we no longer install npm7 as a npm package.
feelepxyz
commented
Mar 4, 2021
| @@ -1319,48 +1319,49 @@ | |||
| let(:latest_allowable_version) { Gem::Version.new("16.3.1") } | |||
|
|
|||
| it "gets the right list of dependencies to update" do | |||
| expect(resolver.dependency_updates_from_full_unlock). | |||
There was a problem hiding this comment.
Spotted this flake here https://github.com/dependabot/dependabot-core/runs/2030784173
jasonrudolph
approved these changes
Mar 4, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this spec has become flaky recently, not clear why but
seems to have fixed it by making the expectation compare the dependency
hash instead of the instance.
Also removed the alias on
npm6as we no longer install npm7 as a npm package.