Add support for Microsoft.Build.CentralPackageVersions #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greysteil
reviewed
Aug 13, 2019
|
I was not able to get things working on windows, but I was able to get them working with WSL2! Currently working on adding some tests. |
david-driscoll
force-pushed
the
feature/csproj-update
branch
3 times, most recently
from
19688a2 to
6f23701
Compare
|
@greysteil when you are able to, any help with additional testing that I should do would be greatly appreciated! |
|
@greysteil let me know what else I can do for this. Thanks! |
|
Sorry for the delay reviewing this @david-driscoll. If you rebase it and squash it down to a single commit I'll get it merged and deployed. |
…date in addition to Include
greysteil
force-pushed
the
feature/csproj-update
branch
from
be12457 to
f7c62cd
Compare
|
Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to add support for two things.
Updatesemantics forPackageReference(and friends) instead ofInclude. (ex https://github.com/OmniSharp/omnisharp-roslyn/blob/master/build/Packages.props)Microsoft.Build.CentralPackageVersions.Microsoft.Build.CentralPackageVersionsadds a new file conventionPackages.propsin addition to Directory.Build.props/targets. It also adds a new elementGlobalPackageReferenceused for private Package References.Some problems I'm aware of...
{}ist(ie I'm not super familiar with ruby, but I'm learning!) 🤣I was hoping I could get some guidance or assistance from someone like @greysteil, obviously you're busy working on everything else, but any help there would be appreciated.
see #1182