Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow null when parsing job.debug field #10974

Merged
merged 1 commit into from
Nov 20, 2024
Merged

allow null when parsing job.debug field #10974

merged 1 commit into from
Nov 20, 2024

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Nov 20, 2024

When parsing a job.json file, the field $.job.debug can appear as null. This handles that.

Issue found during a manual audit of telemetry.

@brettfo brettfo requested a review from a team as a code owner November 20, 2024 20:16
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Nov 20, 2024
@brettfo brettfo mentioned this pull request Nov 20, 2024
Open
@randhircs randhircs merged commit ffe2594 into main Nov 20, 2024
70 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-job-parse branch November 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasgomez238 sebasgomez238 sebasgomez238 approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettfo @sebasgomez238 @randhircs