Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for go ecosystem metrics collection #10953

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Nov 18, 2024

What are you trying to accomplish?

Update the go ecosystem to add support for gathering ecosystem metrics that need to be persisted in datadog via POST /update_jobs/:id/record_ecosystem_meta

Anything you want to highlight for special attention from reviewers?

This is one in a series of PRs to gather ecosystem meta data and persist it in datadog. See earlier PRs for Bundler and NPM

How will you know you've accomplished your goal?

  • I'll be able to see Go ecosystem metrics in datadog

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: go:modules Golang modules label Nov 18, 2024
@amazimbe amazimbe force-pushed the amazimbe/go-metadata-metrics branch 4 times, most recently from a1a44db to 4182ed7 Compare November 19, 2024 16:32
@amazimbe amazimbe marked this pull request as ready for review November 19, 2024 16:32
@amazimbe amazimbe requested a review from a team as a code owner November 19, 2024 16:32
@amazimbe amazimbe force-pushed the amazimbe/go-metadata-metrics branch 3 times, most recently from 55beda8 to 2c1e60c Compare November 20, 2024 16:18
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice works!

@amazimbe amazimbe merged commit b2ad9e0 into main Nov 21, 2024
64 checks passed
@amazimbe amazimbe deleted the amazimbe/go-metadata-metrics branch November 21, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: go:modules Golang modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants