report unix-friendly packages path #10815
Merged
+107
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-targets-not-found
branch
from
9a18705
to
38bd4b5
Compare
JamieMagee
approved these changes
Oct 18, 2024
randhircs
force-pushed
the
dev/brettfo/nuget-targets-not-found
branch
from
38bd4b5
to
f5f39ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running an update in a
packages.configscenario, the path to the packages directory is determined from existing<HintPath>elements. If the path returned looks something like..\packagesthat causes problems on non-Windows machines because the backslash is retained and ultimately the packages are restored to a directory named..?packageswhich is incorrect.The first fix was to simply normalize this path to the Unix standard which Windows can handle just fine.
The second fix was to expand the cases where we run
nuget.exe restorebefore we can update the package; this happens if a package's.targetsfile is directly imported without a guardingCondition="Exists(path)"attribute.This fixes some bugs seen during an internal log audit.