Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty/incomplete commit message #9784

Closed
1 task done
mistic100 opened this issue May 20, 2024 · 23 comments
Closed
1 task done

Empty/incomplete commit message #9784

mistic100 opened this issue May 20, 2024 · 23 comments
Labels
L: git:submodules Git submodules L: github:actions GitHub Actions L: javascript T: bug 🐞 Something isn't working

Comments

@mistic100
Copy link

mistic100 commented May 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

yarn

Package manager version

1

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/mistic100/Photo-Sphere-Viewer/blob/main/package.json

dependabot.yml content

version: 2
updates:
  - package-ecosystem: npm
    directory: '/'
    schedule:
      interval: daily
    assignees:
      - mistic100
    ignore:
      - dependency-name: '*'
        update-types: ['version-update:semver-patch']
      - dependency-name: '@typescript-eslint/*'
        update-types: ['version-update:semver-minor']
      - dependency-name: 'marked'
        update-types: ['version-update:semver-major']
    commit-message:
      prefix: 'chore'
      include: 'scope'
  - package-ecosystem: github-actions
    directory: '/'
    schedule:
      interval: weekly
    assignees:
      - mistic100
    commit-message:
      prefix: 'chore'
      include: 'scope'

Updated dependency

No response

What you expected to see, versus what you actually saw

Recent update commits message are empty, only containing ---, see examples bellow. On the other hand the PR title is complete.

I didn't made any recent changes in the configuration.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

Smallest manifest that reproduces the issue

No response

@mistic100 mistic100 added the T: bug 🐞 Something isn't working label May 20, 2024
@slawekjaranowski
Copy link
Contributor

@l0b0
Copy link
Contributor

l0b0 commented May 20, 2024

Another example (fixed manually to make it pass gitlint), with an original commit message of:

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

.github/dependabot.yml:

version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: daily
    commit-message:
      prefix: "build(deps)"

@federicobond
Copy link

This is happening for me too with Python dependencies.

kachick referenced this issue in kachick/wait-other-jobs May 21, 2024
updated-dependencies:
- dependency-name: "@octokit/graphql-schema"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: octokit-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@remarkablemark
Copy link

@fredrikaverpil
Copy link
Contributor

💸 🔥

@martincostello
Copy link
Contributor

This appears to be affecting all package managers - I'm seeing it for GitHub Actions, npm packages and NuGet packages.

@Uaitt
Copy link

Uaitt commented May 21, 2024

Happens in bundler too 🥲.

@mjanzs
Copy link

mjanzs commented May 21, 2024

We have same issue on multiple private repos (maven)

@cpswan
Copy link

cpswan commented May 21, 2024

A little before and after example:

before

build(deps): Update atsdk requirement
Updates the requirements on [atsdk](https://github.com/atsign-foundation/at_python) to permit the latest version.

Updates `atsdk` to 0.2.14
- [Release notes](https://github.com/atsign-foundation/at_python/releases)
- [Commits](https://github.com/atsign-foundation/at_python/compare/v0.2.13...v0.2.14)

---
updated-dependencies:
- dependency-name: atsdk
  dependency-type: direct:production
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <[email protected]>

After

---
updated-dependencies:
- dependency-name: atsdk
  dependency-type: direct:production
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <[email protected]>

So it's not just missing the summary line (and failing Semantic PR checks), but there's a whole bunch of other content that's missing. Everything before --- is missing and --- becomes the commit summary :/

Those are for pip, but I'm seeing this across all package managers.

@dhensby
Copy link

dhensby commented May 21, 2024

In case this is helpful in tracking down when this went live:

Last good dependabot commit message I've seen was 2024-05-20T17:36:14Z and first bad commit was 2024-05-20T18:36:23Z - so looks like a dependabot release some time between 17:36 and 18:36 for the repos I've got visibility over.

@samtrion
Copy link

samtrion commented May 21, 2024

Same issue with the ecosystems nuget, gitmodules, github-actions & devcontainers

@zhu0629
Copy link

zhu0629 commented May 22, 2024

Same issue with the ecosystems npm, pip

@leethree
Copy link

leethree commented May 22, 2024

We are seeing this in our repo when dependabot PRs were squash merged

image

@brunoalr
Copy link

just for completeness: it also happens on gitsubmodule ecosystem. Example: https://github.com/OpenImageDebugger/OpenImageDebugger/pull/339/commits

@matteovivona
Copy link

Same here even with package-ecosystem: "github-actions". The custom commit-message is completely ignored

@gastaldi
Copy link

Any estimate when this is going to be fixed?

@phillipuniverse
Copy link
Contributor

I just squash-merged a commit about 5 minutes ago with @dependabot squash and merge and it looks like the commit message was fixed!

image

This one was for the github actions ecosystem.

I also confirmed one for the python ecosystem, specifically Poetry:

image

Looks like a fix got deployed very recently.

@johanneswuerbach
Copy link

the fix for this issue has been deployed

According to GitHub Support 🎉

@Pyker
Copy link

Pyker commented May 23, 2024

This appears to be fixed for new PRs, but current broken PRs are still broken, even if you do @dependbot recreate or @dependabot squash and merge.

@samtrion
Copy link

This appears to be fixed for new PRs, but current broken PRs are still broken, even if you do @dependbot recreate or @dependabot squash and merge.

Ya, you have to life with that or manually fix the git commits/history.

char0n referenced this issue in swagger-api/swagger-ui May 23, 2024
@TheRealWaldo
Copy link

With hundreds, if not thousands, of Dependbot PRs open with invalid ---'s in the messages, wouldn't it be at least a little better to fix @dependabot recreate to fix these?

masnagam added a commit to bee-browser/bee that referenced this issue Jun 22, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules L: github:actions GitHub Actions L: javascript T: bug 🐞 Something isn't working
Projects
Status: Done
Development

No branches or pull requests