Merge pull request #3917 from PeterDaveHelloKitchen/ImproveShellScript

Double quote variables in shellscript
dependabot · Jun 16, 2021 · c7523c8 · c7523c8
2 parents df00c3d + a59d52a
commit c7523c8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/dep/helpers/build b/dep/helpers/build
@@ -18,7 +18,7 @@ if [ ! -d "$install_dir/bin" ]; then
 fi
 
 helpers_dir="$(dirname "${BASH_SOURCE[0]}")"
-cd $helpers_dir
+cd "$helpers_dir"
 
 os="$(uname -s | tr '[:upper:]' '[:lower:]')"
 echo "building $install_dir/bin/helper"

diff --git a/go_modules/helpers/build b/go_modules/helpers/build
@@ -18,7 +18,7 @@ if [ ! -d "$install_dir/bin" ]; then
 fi
 
 helpers_dir="$(dirname "${BASH_SOURCE[0]}")"
-cd $helpers_dir
+cd "$helpers_dir"
 
 os="$(uname -s | tr '[:upper:]' '[:lower:]')"
 echo "building $install_dir/bin/helper"

diff --git a/hex/helpers/build b/hex/helpers/build
@@ -8,7 +8,7 @@ if [ -z "$install_dir" ]; then
   exit 1
 fi
 
-mkdir -p $install_dir
+mkdir -p "$install_dir"
 
 mix local.hex --force
 mix archive.install hex nerves_bootstrap --force
@@ -20,9 +20,9 @@ case `uname` in
   *) CP_OPTS='-r' ;;
 esac
 
-cp $CP_OPTS "$helpers_dir/lib" $install_dir
-cp $CP_OPTS "$helpers_dir/mix.exs" $install_dir
-cp $CP_OPTS "$helpers_dir/mix.lock" $install_dir
+cp $CP_OPTS "$helpers_dir/lib" "$install_dir"
+cp $CP_OPTS "$helpers_dir/mix.exs" "$install_dir"
+cp $CP_OPTS "$helpers_dir/mix.lock" "$install_dir"
 
 cd "$install_dir"
 mix deps.get