ecosystem_versions replaces package_manager field
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
force-pushed
the
ecosystem_versions-replace-package-manager-field
branch
from
10f1552
to
8a8dbc0
Compare
bdragon
approved these changes
Jul 11, 2023
|
I tried to test this against the smoke tests using a codespace and was able to successfully build it, but then ran into the following error: @jeffwidman ➜ /workspaces/smoke-tests (migrate-record-package-manager-version-to-record-ecosystem-versions ✗) $ ../cli/dependabot test -f tests/smoke-bundler.yaml
cli | 2023/07/11 19:11:35 using image ghcr.io/github/dependabot-update-job-proxy/dependabot-update-job-proxy:latest at sha256:3268f53f957cc99b75cadf172be86f9d92a4400038c59357a4b05af12b66ed50
cli | 2023/07/11 19:11:35 using image ghcr.io/dependabot/dependabot-updater-cargo at sha256:c4ba35d041c7b4519f7b289e00940e70f1a3df102f8f581f6d0533a8827c99f4
proxy | 2023/07/11 19:11:36 proxy starting, commit: d7a27fb6ccdfcb34a156f90abed68233895dd023
proxy | 2023/07/11 19:11:36 initializing metrics client: No address passed and autodetection from environment failed
proxy | 2023/07/11 19:11:36 Listening (:1080)
proxy | 2023/07/11 19:11:37 0/0 calls cached (0%)
cli | 2023/07/11 19:11:38 failed to start exec: http: invalid Host headerAt this point, I think it's going to be faster to merge/release and test that way than keep futzing with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confused myself in the previous two PR's... the
Ecosystemfield is actually removed, and thePackageManagerfield is replaced by theEcosystemVersionsfield.As explained in #146, there may
be an inner
PackageManagerfield, which is optional. But no need tomap it out in the struct, at least not yet.
For background context:
RecordPackageManagerVersiontoRecordEcosystemVersions#145package-managersfield is now optional #146ecosystemparam dependabot-core#7492record_ecosystem_versionsendpoint. dependabot-core#7517Caught this discrepancy over here: