Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved webpack support #580

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

cwillisf
Copy link
Contributor

@cwillisf cwillisf commented Aug 26, 2020

This change improves support for webpack in two ways:

Tests are included for these new features.

support multiple chained inline webpack loaders separated with '!'
support (ignore) initial '!' in inline webpack loader chain
By exporting an array, webpack can support multiple configurations
exported from the same file. Something like:
module.exports = [{...}, {...}];
See here for more details:
https://webpack.js.org/configuration/configuration-types/#exporting-multiple-configurations
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #580 into main will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   98.48%   98.53%   +0.04%     
==========================================
  Files          47       47              
  Lines         925      954      +29     
==========================================
+ Hits          911      940      +29     
  Misses         14       14              
Impacted Files Coverage Δ
src/detector/importDeclaration.js 100.00% <ø> (ø)
src/detector/typescriptImportEqualsDeclaration.js 100.00% <ø> (ø)
src/detector/extract.js 100.00% <100.00%> (ø)
src/detector/requireCallExpression.js 100.00% <100.00%> (ø)
src/index.js 85.45% <100.00%> (-0.26%) ⬇️
src/parser/sass.js 100.00% <100.00%> (ø)
src/special/gatsby.js 100.00% <100.00%> (ø)
src/special/webpack.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6264085...a33accd. Read the comment docs.

Copy link
Collaborator

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rumpl rumpl merged commit cf2cbbb into depcheck:main Sep 1, 2020
@cwillisf cwillisf deleted the improved-webpack-support branch September 1, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants