Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to parse JSON5 babelrc files #556

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Try to parse JSON5 babelrc files #556

merged 1 commit into from
Jul 6, 2020

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Jul 5, 2020

Fixes #527

@codecov
Copy link

codecov bot commented Jul 5, 2020 •
edited
Loading

Codecov Report

Merging #556 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          46       46           
  Lines         906      908    +2     
=======================================
+ Hits          892      894    +2     
  Misses         14       14
Impacted Files Coverage Δ
src/utils/cli-tools.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17174a...54bddef. Read the comment docs.

@rumpl rumpl requested a review from znarf July 5, 2020 17:01
znarf
znarf approved these changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

LinusU
LinusU approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rumpl rumpl merged commit cf61bb8 into master Jul 6, 2020
@rumpl rumpl deleted the feat-json5 branch July 6, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

@znarf znarf znarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babelrc format
3 participants
@rumpl @znarf @LinusU