Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index.d.ts #458

Merged
merged 2 commits into from
Nov 3, 2019
Merged

Add index.d.ts #458

merged 2 commits into from
Nov 3, 2019

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

@sveyret regarding your email look at this :)

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          38       38           
  Lines         728      728           
=======================================
  Hits          722      722           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d2651...17da0e1. Read the comment docs.

@sveyret
Copy link
Contributor

sveyret commented Nov 2, 2019

It looks like this does not have the latest modifications posted by @rumpl to DefinitlyTyped.

@VincentLanglet
Copy link
Contributor Author

Indeed, I found the PR and update the index.d.ts file

@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

Definitely typed has a test for the d.ts file, could we add it too?

@VincentLanglet
Copy link
Contributor Author

I don't remember packages with test for the d.ts file, except DefinitivelyTyped.

If you want to add test for this file, you need something to run theses tests.
I can't help about this.

@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

It's ok for now

@rumpl rumpl merged commit 6135bb0 into depcheck:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants