Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't appear to work 0.6.7 #220

Closed
kaihendry opened this issue Aug 11, 2017 · 5 comments
Closed

Doesn't appear to work 0.6.7 #220

kaihendry opened this issue Aug 11, 2017 · 5 comments

Comments

@kaihendry
Copy link

~/eg$ depcheck --specials webpack,eslint            
Unused dependencies
* babel-core
* babel-loader
* babel-preset-es2015
* lodash
* moment
* moment-duration-format
* path
* request
* standard
* url
* uuid
* uuid-parse
* vue-loader
* vue-material
* vue-template-compiler
* vue-video
* vue-video-player
* webpack-dev-server
* zencoder
Unused devDependencies
* async-waterfall
* babel-eslint
* css-loader
* eslint
* eslint-config-standard
* eslint-config-standard-jsx
* eslint-plugin-html
* eslint-plugin-import
* eslint-plugin-node
* eslint-plugin-promise
* eslint-plugin-react
* eslint-plugin-standard
* file-loader
* json-loader
* style-loader
~/eg$ grep -r uuid src | grep require
src/components/Clip.vue:const uuidv4 = require('uuid/v4')
~/eg$ grep json-loader webpack.config.js
        loader: 'json-loader'

I use uuid as well as json-loader, so why the false positives?

@lijunle
Copy link
Member

lijunle commented Aug 11, 2017 via email

@kaihendry
Copy link
Author

{"dependencies":["babel-core","babel-loader","lodash","moment","moment-duration-format","path","request","standard","url","uuid","uuid-parse","vue-loader","vue-material","vue-template-compiler","vue-video","vue-video-player","zencoder"],"devDependencies":["async-waterfall","babel-eslint","css-loader","eslint-config-standard","eslint-config-standard-jsx","eslint-plugin-html","eslint-plugin-import","eslint-plugin-node","eslint-plugin-promise","eslint-plugin-react","eslint-plugin-standard","file-loader","json-loader","style-loader"],"missing":{},"using":{"babel-preset-es2015":["/home/hendry/spuul/video-ingestion/.babelrc"],"webpack":["/home/hendry/spuul/video-ingestion/package.json","/home/hendry/spuul/video-ingestion/webpack.config.js"],"webpack-dev-server":["/home/hendry/spuul/video-ingestion/package.json"],"eslint":["/home/hendry/spuul/video-ingestion/package.json"],"vue":["/home/hendry/spuul/video-ingestion/src/main.js","/home/hendry/spuul/video-ingestion/src/router/index.js"],"vue-async-computed":["/home/hendry/spuul/video-ingestion/src/main.js"],"vue-timeago":["/home/hendry/spuul/video-ingestion/src/main.js"],"vue-router":["/home/hendry/spuul/video-ingestion/src/router/index.js"],"aws-sdk":["/home/hendry/spuul/video-ingestion/src/services/aws.js"]},"invalidFiles":{},"invalidDirs":{}}

It's not giving me much to go on ...

@niftylettuce
Copy link

Doesn't work with node v8.x either

@niftylettuce
Copy link

Upon using --json I see there's some issue with renderSync in parseSASS?

https://github.com/depcheck/depcheck/blob/master/src/parser/sass.js#L9

TypeError: Cannot read property 'renderSync' of null\n    at parseSASS (/Users/niftylettuce/.nvm/versions/node/v8.3.0/lib/node_modules/depcheck/dist/parser/sass.js:27:30)\n    at /Users/niftylettuce/.nvm/versions/node/v8.3.0/lib/node_modules/depcheck/dist/check.js:129:17\n    at tryToString (fs.js:513:3)

@mnkhouri
Copy link
Member

mnkhouri commented Sep 7, 2018

@niftylettuce for your issue Cannot read property 'renderSync' of null, it is likely because you do not have node-sass installed, which is required for parsing sass.

There have been a couple of versions (with several fixes) published since this issue was filed -- please don't hesitate to open a new issue if you have a problem!

@mnkhouri mnkhouri closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants