Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilot session UI changes to pattern 2 tasks #32920

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Nov 6, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Some minor changes were requested from the results of the first pilot session
  • Remove shadow on cards
  • Reduce width of gray card
  • Adjust gray card to have the standard name title: [name]
  • Adjust user data to be consistent across flows (use the Rita Jackson name in the post-flow UI, also shown in the mocks)
  • Add button to post-flow UI on home page
  • Blue task remove Note: Any updates you make here will only be reflected
    in this form.
  • gray task shows the edit page with a button that says 'Save to Profile', instead of 'Save'.

Related issue(s)

Testing done

  • Updated e2e tests for new

Screenshots

Screenshot 2024-11-05 at 10 46 23 PM

Screenshot 2024-11-06 at 9 09 33 AM

Screenshot 2024-11-06 at 9 08 46 AM

Screenshot 2024-11-06 at 9 08 30 AM

What areas of the site does it impact?

Authed Exp Patterns Mock Form

Acceptance criteria

  • Updates made

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@adamwhitlock1 adamwhitlock1 requested review from a team as code owners November 6, 2024 16:11
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adamwhitlock1 adamwhitlock1 merged commit 7646270 into main Nov 6, 2024
69 of 70 checks passed
@adamwhitlock1 adamwhitlock1 deleted the authed-patterns/aw/187/pilot-session-changes branch November 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants