Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DR-67960] fix HLR keyboard only cypress test (and hopefully fix SC e2e test) #26465

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

anniebtran
Copy link
Contributor

@anniebtran anniebtran commented Oct 31, 2023

Summary

  • (Summarize the changes that have been made to the platform)

Fixing some appeals/Decision Reviews E2E tests before merges get blocked

  • (Which team do you work for, does your team own the maintenance of this component?)

Benefits Decision Reviews

Related issue(s)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/fix/DR-HLR-keyboard-only-e2e-test/main October 31, 2023 14:00 Inactive
Copy link
Contributor

@Mottie Mottie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for looking into this!

@va-vfs-bot va-vfs-bot temporarily deployed to master/fix/DR-HLR-keyboard-only-e2e-test/main October 31, 2023 15:37 Inactive
@anniebtran anniebtran changed the title fix HLR keyboard only cypress test [DR-67960] fix HLR keyboard only cypress test (and hopefully fix SC e2e test) Oct 31, 2023
@anniebtran anniebtran marked this pull request as ready for review October 31, 2023 17:24
@anniebtran anniebtran requested review from a team as code owners October 31, 2023 17:24
@anniebtran
Copy link
Contributor Author

@Mottie I tried to fix the SC e2e failure — seems like it may have worked this time, but it could be intermittent... seems like there's not a solid fix for it, but this change might help at least.

Copy link
Contributor

@Mottie Mottie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wiling to try it! Thanks!

@anniebtran anniebtran merged commit edd3575 into main Oct 31, 2023
88 of 90 checks passed
@anniebtran anniebtran deleted the fix/DR-HLR-keyboard-only-e2e-test branch October 31, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants