-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VA-14277: Preserve wait times panel with Zero wait time #25331
Conversation
8773ceb
to
fcf80c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but check the question.
src/applications/static-pages/facilities/FacilityAppointmentWaitTimesWidget.jsx
Outdated
Show resolved
Hide resolved
@maxx1128 I know the vetswebsite PR template has no QA steps section. But it would be nice to see this. Is there no way to QA this on a review instance? |
@swirtSJW I don't know of any current clinics in the CMS that reproduce the same issue, since the wait times for the examples on the ticket have since changed to numbers higher than 0. But I can include the instructions for reproducing this in local code, so it can be checked on a local instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Wait Times panels had a bug in the template where if the number of days to wait was
0
, it only showed that number instead the panel itself. This pull request makes two changes:0
, the panel still renders.Summary
Related issue(s)
Testing done
0
character on the page.0
waiting days for existing patients.Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
VAMC Clinic locations
Acceptance criteria
Local Testing
content-build
withyarn serve
vets-website
withyarn watch --env api=https://dev-api.va.gov entry=facilities,static-pages
src/applications/static-pages/facilities/FacilityAppointmentWaitTimesWidget.jsx
invets-website
, add the following line below line 47:http://localhost:3002/butler-health-care/locations/cranberry-township-va-clinic/
and expand the "Primary Care" accordion. The "Existing Patients" panel should now appear as if there are zero wait days.Quality Assurance & Testing
Error Handling
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?