Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDOT- 404 Error for if Veteran supplies not found and Veteran not found #12730

Merged
merged 1 commit into from
May 19, 2020

Conversation

maharielrosario
Copy link

Description

This PR focuses on adding a 404 error message if the Veteran supplies are not found or if the Veteran is not found in the DLC database.

Testing done

[email protected]. (Veteran supplies not found)
[email protected] (Veteran not found)

Screenshots

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@maharielrosario maharielrosario requested a review from a team May 19, 2020 20:23
@maharielrosario maharielrosario requested review from a team as code owners May 19, 2020 20:23
@maharielrosario maharielrosario self-assigned this May 19, 2020
@va-bot va-bot temporarily deployed to vetsgov-pr-12730 May 19, 2020 20:24 Inactive
@maharielrosario maharielrosario changed the title MDOT- 404 Errors for if Veteran supplies not found and Veteran not found MDOT- 404 Error for if Veteran supplies not found and Veteran not found May 19, 2020
@maharielrosario maharielrosario merged commit fbf1ba8 into master May 19, 2020
@maharielrosario maharielrosario deleted the mr0sari0-mdot-404-errors branch May 19, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants