Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced address city max length to 30 characters for 10-10EZ and 10-10EZR schemas #809

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Reduced address city max length to 30 characters for 10-10EZ and 10-10EZR schemas #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/10-10EZ-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down Expand Up @@ -1655,7 +1655,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down Expand Up @@ -1931,7 +1931,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down
6 changes: 3 additions & 3 deletions dist/10-10EZR-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down Expand Up @@ -478,7 +478,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down Expand Up @@ -801,7 +801,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down
2 changes: 1 addition & 1 deletion dist/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,7 +2010,7 @@
"city": {
"type": "string",
"minLength": 1,
"maxLength": 51,
"maxLength": 30,
"pattern": "^.*\\S.*"
},
"postalCode": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vets-json-schema",
"version": "20.29.1",
"version": "20.30.1",
"repository": {
"type": "git",
"url": "git+https://github.com/department-of-veterans-affairs/vets-json-schema.git"
Expand Down
4 changes: 2 additions & 2 deletions src/common/definitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ const hcaAddress = (() => {
city: {
type: 'string',
minLength: 1,
maxLength: 51,
maxLength: 30,
...rejectOnlyWhitespace,
},
postalCode: {
Expand All @@ -158,7 +158,7 @@ const hcaAddress = (() => {
},
},
required: ['street', 'city', 'country'],
}
};
})();

const address = (() => {
Expand Down
4 changes: 2 additions & 2 deletions test/common/definitions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ describe('schema definitions', () => {
street: stringGenerate(23),
street2: stringGenerate(13),
street3: stringGenerate(5),
city: stringGenerate(43),
city: stringGenerate(27),
postalCode: stringGenerate(5),
},
],
Expand All @@ -433,7 +433,7 @@ describe('schema definitions', () => {
street: stringGenerate(31),
street2: stringGenerate(31),
street3: stringGenerate(31),
city: stringGenerate(52),
city: stringGenerate(31),
postalCode: stringGenerate(52),
},
// doesn't allow street, cities, or provinces with only spaces
Expand Down
Loading