-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move content-build's breadcrumbs liquid logic to a liquid filter #2741
Move content-build's breadcrumbs liquid logic to a liquid filter #2741
Comments
FYI @FranECross @randimays @chriskim2311 for outcome from the Breadcrumbs spike on V3 component migration. I've added an AC here to make sure PW is looped into code review on this change, so we can test our products. |
@xiongjaneg Take back to Design System with timing |
Clarification on that thread re: the suggested May 3 deadline: https://dsva.slack.com/archives/C01DBGX4P45/p1711563151493419?thread_ts=1710356217.340919&cid=C01DBGX4P45
|
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc |
Will carry over due to Sitewide team needing more time to review. CC @jilladams |
User Story or Problem Statement
The breadcrumbs component in
content-build
will be converted to the V3 component. But first, the logic for modifying the breadcrumbs in the template must be separated into a liquid filter since the component will only accept an array of data objects. This filter must also be thoroughly tested, since the breadcrumbs component will affect most of the pages oncontent-build
.The current component update deadline is May 3.
This ticket is a blocker for #2742.
Description or Additional Context
The filter must cover the following points:
crumbs
variable after it is potentially passed into the previous two filters,deriveLastBreadcrumbsFromPath
andderiveLcBreadcrumbs
.crumb.url.path
.path
variable.crumb.url.path
equals"/"
andhideHomeBreadcrumb
is false, then it will usecustomHomeCrumbText
for the breadcrumb's text (if available). If there's no custom text, it uses the text from the crumb object.breadcrumb-list
parameter.Please reference
src/site/includes/breadcrumbs.drupal.liquid
for more details of what logic to carry over.Change management
Note: 57 products use the Liquid template for breadcrumbs, per Design System: department-of-veterans-affairs/va.gov-cms#14724 (comment)
Not all of those products are Sitewide products. Design System has agreed to help code review on behalf of the other affected products: https://dsva.slack.com/archives/C01DBGX4P45/p1709666843934939?thread_ts=1709664794.685379&cid=C01DBGX4P45
We should also coordinate with DS team to get a change announcement posted for awareness, and/or report in Team of Teams, before we ship.
Steps for Implementation
Acceptance Criteria
The text was updated successfully, but these errors were encountered: