Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components and pattern standards] Your content or feature doesn't use standard global navigation components or is missing a standard navigation component. (04.02.1) #54299

Closed
shiragoodman opened this issue Feb 28, 2023 · 5 comments
Labels
accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue04.02 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS design exp-std-site-location Facilities Sitewide Facilities products (VAMC, Vet Center, etc) Findability ia sitewide Staging VAMC

Comments

@shiragoodman
Copy link
Contributor

General Information

VFS team name

Sitewide Facilities

VFS product name

VAMC

VFS feature name

VAMC Lovell Federal Health care

Point of Contact/Reviewers

Sara Sterkenburg - @sterkenburgsara - IA

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Your content or feature doesn't use standard global navigation components or is missing a standard navigation component.

Issue Details

All breadcrumbs (except for "events" page) are missing the initial segment "home" that would route users back to VA.gov home.

Link, screenshot or steps to recreate

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/52672_Sara_040201.png

VA.gov Experience Standard

Category Number 04, Issue Number 02

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

I synced with Mikki Northuis on this one, and she let me know that your previous testing had shown that users clicked home intending to reach the landing page for the Lovell site, not the larger Va.gov home. There is a fix/solution in place for this though, which is to use the breadcrumb segment "Va.gov home" instead of just "home." Please add this breadcrumb segment to all affected pages within your product.


VFS Guidance

  • Close the ticket when the issue has been resolved or validated by your Product Owner
  • If your team has additional questions or needs Platform help validating the issue, please comment on the ticket
  • Some feedback provided may be out of scope for your iteration of the product, however, Platform's OCTO leadership has stated that all identified issues need to be documented and it is still your responsibility to resolve the issue.
  • If you do not believe that this Staging Review issue ticket is the responsibility of your team, comment below providing an explanation and who you believe is responsible. Please tag the Point of Contact/Reviewers. Governance team will research and will follow up.
@shiragoodman shiragoodman added accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue04.02 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS design ia launch-blocking launch blocking issue found in Collab Cycle Staging VA Lovell Lovell FHCC health care VAMC labels Feb 28, 2023
@sterkenburgsara sterkenburgsara removed the launch-blocking launch blocking issue found in Collab Cycle label Feb 28, 2023
@davidmpickett davidmpickett removed the VA Lovell Lovell FHCC health care label Mar 13, 2023
@davidmpickett
Copy link
Contributor

Removing the Lovell tag as this is an issue for all VAMCs

@mmiddaugh
Copy link
Contributor

@mmiddaugh
Copy link
Contributor

This should be resolved by Replace content-build breadcrumb partial with V3 Component #17411/#2742 - which is blocked by #17410/#2741

@jilladams
Copy link
Contributor

This ticket showed up In Progress when we transitioned boards, so I took a look to see if the bigger picture breadcrumb / component migration effort to add VA.gov home to all breadcrumbs has fixed it. However, it doesn't include any flavor of Home on Lovell:

Screenshot 2024-06-27 at 4 20 33 PM

Not urgent, just noting it while I'm here. I'll chat with Laura about why it's in progress sometime when things are less busy.

@laflannery
Copy link
Contributor

With the upgrade to v3 the breadcrumb component this is now resolved:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue04.02 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS design exp-std-site-location Facilities Sitewide Facilities products (VAMC, Vet Center, etc) Findability ia sitewide Staging VAMC
Projects
None yet
Development

No branches or pull requests

7 participants