-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into ghas-enforcement-codeql
- Loading branch information
Showing
133 changed files
with
9,060 additions
and
3,950 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
--- | ||
name: "DST - Component Figma" | ||
about: INTERNAL DST USE ONLY | ||
title: "[component name] - Design" | ||
labels: platform-design-system-team | ||
assignees: babsdenney, danbrady | ||
|
||
--- | ||
|
||
## Configuring this issue | ||
- [ ] Add issue to appropriate epic | ||
- [ ] Add Design System component label (such as `va-alert`) | ||
- [ ] Add `component-new` or `component-update` label, if applicable | ||
- [ ] Complete sections below | ||
- [ ] Delete this section once complete | ||
|
||
## Description | ||
Create [component name] and/or update in Figma. | ||
|
||
|
||
## Details | ||
Confluence page with instructions: https://vfs.atlassian.net/l/cp/JR0BtAa1 | ||
|
||
|
||
## Tasks | ||
- [ ] Create designs for component in Figma | ||
- [ ] Review designs with PO and/or other DST designers | ||
- [ ] Review designs with an accessibility specialist | ||
- [ ] Review designs with DST members | ||
- [ ] Address any comments from reviews, if necessary | ||
- [ ] Comment on this ticket with any accessibility considerations engineers may need to know | ||
- [ ] Comment on this ticket with content specifications (e.g. labels and error messages) | ||
- [ ] Comment on this ticket with a link to the designs and post in DST Slack channel | ||
|
||
|
||
## Acceptance Criteria | ||
Styles & Variables/Token | ||
- [ ] All components should be connected to VADS Component Library styles & Variables | ||
- [ ] All components should be connected to the proper style or variable/token | ||
- [ ] Colors: connected to the correct color token (not primitive!) - can be found in local variables library | ||
- [ ] Typography: connected to the correct text style - under local styles | ||
- [ ] Spacing: connected to the correct spacing token or primitive | ||
- [ ] Icons: connected to correct icon - can be found on foundation page | ||
Auto layout | ||
- [ ] Components should be as reactive as possible. Most, if not all, components should be able to be resize for either mobile, tablet, or desktop sizes | ||
- [ ] The correct spacing should be applied to auto layout | ||
Properties | ||
Note: Not all components need every property. It will differ component to component | ||
- [ ] Variants: Should be used when the component has several states i.e primary, secondary, error | ||
- [ ] Boolean: Should be used if the component has a part that does not always need to be shown i.e icons, nested components and mobile view | ||
- [ ] Text: Should be used when the test on a component needs to be changed. There are some exceptions to this if the component has several variants that need to have different/specific text. When you change the text on the parent component it will change all of the variants | ||
- [ ] Instance Swap | ||
- [ ] Should be used if there is a part of the component that needs to be switched out but nothing else needs to change i.e. icons Color contrast (Pro Tip: The plugin “Contrast” can help with this.) | ||
- [ ] Test as a DS library user | ||
- [ ] Connect your Figma design file to the DS library found in the Assets panel, Team Library (open book icon) | ||
- [ ] After connecting to the library, use the Assets panel to view all components | ||
- [ ] Does the component naming make sense and follow storybook? | ||
- [ ] Try to break the component! Test on asset NOT parent component | ||
- [ ] Expand/shrink the asset and put into containers | ||
- [ ] change body text and/or header from a sentence to paragraph | ||
- [ ] make sure text wraps correctly | ||
- [ ] the component should expand or shrink with text | ||
- [ ] Test all combinations of properties | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: Pull Request | ||
|
||
on: | ||
pull_request: | ||
types: [ready_for_review, synchronize, reopened, opened] | ||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
environment: [{ bucket: dev-design.va.gov, config: dev.yml }, { bucket: staging-design.va.gov, config: staging.yml }, { bucket: design.va.gov, config: prod.yml }] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- name: Use Node.js 14.x | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 14.x | ||
cache: 'npm' | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: 2.7.5 # Not needed with a .ruby-version file | ||
bundler-cache: true # runs 'bundle install' and caches installed gems automatically | ||
- run: npm install | ||
- run: npm run-script build | ||
- run: bundle exec jekyll build --config _config.yml,jekyll-configs/${{ matrix.environment.config }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
18.14.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.