Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formation: update blue colors to USWDS v3 colors #985

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

powellkerry
Copy link
Contributor

Description

Update the current blue colors in formation to use the USWDS v3 colors. Color mappings are as follows:

//================
//  USWDS Colors
//===============
$color-aqua:                 #00bde3;
$color-aqua-dark:            #009ec1;
$color-aqua-lightest:        #e1f3f8;
$color-blue:                 #005ea2;
$color-blue-darkest:         #162e51;

$color-primary:              $color-blue;
$color-primary-darker:       #1a4480;
$color-primary-darkest:      $color-blue-darkest;

$color-primary-alt:          $color-aqua;
$color-primary-alt-light:    #97d4ea;
$color-primary-alt-lightest: $color-aqua-lightest;
$color-primary-alt-dark:     #28a0cb;

Issue link: department-of-veterans-affairs/vets-design-system-documentation#2228

Testing done

  • Local testing on vets-website. I am wanting to publish a beta version of formation for additional local testing

Screenshots

Color change comparison:
colors

Acceptance criteria

  • [ ]

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@powellkerry powellkerry requested a review from a team as a code owner November 3, 2023 21:01
@@ -31,34 +31,39 @@ $h6-font-size: 1.5rem;
$text-max-width: 70rem; // Note: USWDS value is 53rem;
$site-max-width: 100rem; // Worksout to about 1000px. USWDS value is 1040px


//================
// USWDS Colors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formation uses USWDS v1 so a minor nit here would be that we mention this is USWDS v3 for clarity.

@powellkerry powellkerry merged commit 410fa5f into master Nov 6, 2023
6 checks passed
@powellkerry powellkerry deleted the 2228-formation-blue-USWDS branch November 6, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants