Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eslint transformer for OMBInfo #966

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

it-harrison
Copy link
Contributor

Description

This PR removes an eslint transformer for the OMBInfo React component which has been removed from the component-library repo

Testing done

local testing

Screenshots

n/a

Acceptance criteria

  • [ ]

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@it-harrison it-harrison requested a review from a team as a code owner September 22, 2023 20:44
@it-harrison it-harrison requested a review from a team as a code owner September 22, 2023 20:54
Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing left to do here is to update the eslint-plugin version number and publish the NPM package after it's merged.

vets-website will need to be updated with the latest version of that package too.

@it-harrison it-harrison merged commit 9578cd6 into master Sep 26, 2023
6 checks passed
@it-harrison it-harrison deleted the 1359-OMBInfo-deprecation branch September 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants