Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16461: Fixes phone export and adds new fields #20010

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Dec 3, 2024

Description

Relates to #16461

Testing done

Manually

Screenshots

Screenshot 2024-12-03 at 13 25 08

QA steps

  • As a content admin, visit the phone number audit view.
  • Select "VAMC Facility" from the Content type filter.
  • Click Filter
  • Confirm that the view is properly filtered
  • Click Download CSV
  • Confirm that you are redirected to the phone numbers audit view.
  • Confirm that the view is still filtered as it was.
  • Click the here of "Download the file here"
  • Confirm that the file downloads the results returned from the filtered view.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 19:27 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 3, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 21:43 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@omahane omahane requested a review from dsasser December 3, 2024 22:06
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2024 12:20 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 13:09 Destroyed
Copy link

github-actions bot commented Dec 5, 2024

Checking composer.lock changes...

Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great I went through the config and didn't see any glaring issues, and the QA steps proved successful:
Screenshot 2024-12-05 at 11 11 38 AM

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 19:15 Destroyed
Copy link

github-actions bot commented Dec 5, 2024

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-magni

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

@omahane omahane merged commit 2e8855d into main Dec 5, 2024
18 checks passed
@omahane omahane deleted the VACMS-16461-content-audit-phone-numbers branch December 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants