VACMC-19551: CLP draft promos

[omahane]

Description

Relates to #19551

Testing done

• Manually
• Cypress

Screenshots

QA steps

The Demo environment is working to test CLP promo blocks: https://vacms-19551-clp-draft-promos-6etihu8cdfkjknny8ndlvmkoqul6tkah.demo.cms.va.gov/

Set up user

• As an admin, log in.
• Assign the following role(s) the QA Content Publisher:
  • "Content admin"
• Assign the following section(s) to QA Content Publisher:
  • "VACO"

Edit a Block

We need to see whether the Promo block that is being called on the Benefits hub landing page displays the default revision or the latest revision.

• Edit the Find National Cemetery Administration Information block
• Make a change, appending "DRAFT" to the link text (to distinguish it from the default revision)
• Select "Draft" in the Change to dropdown
• Save

Check the block on a Benefits Hub Landing page

• Check the Benefits Landing Page VA burial benefits and memorial items node:view
• Scroll down to the Right rail section
• Confirm that the Promo link does not include the word "DRAFT"
• Edit the page
• Open up the Right Rail in the form
• Click the Promo
• Confirm that the link text does not include the word "DRAFT"

Note: There's no reason to show the latest revision in the node:edit form, as this cannot be edited here, anyway.

Editing CLP

• Go to the VACMS-19551-clp-promo-blocks-workflow Google sheet
• As QA Content Publisher do the following for each row:
  • Edit the node in the Node id column
  • Confirm that the node is in the Node revision state (start) when starting
  • Edit the Promo block with the Block title
  • Confirm that the block is in the Block state (start) when you begin editing
  • Edit the Promo, , appending the word "DRAFT" or "PUB" to the link text, based on the Block action
  • Confirm that the block is in the Block state (end) when you finish editing the block
  • At the end of the promo block work, save the node as described in the Node action
  • Confirm that the node is in the Node revision state (end) after saving
  • Add to the Results (node:edit) the results
  • Add to the Results (node:view) the results

Checking the front end

Note: The front end of each page should mirror the node:view, but we should publish to confirm. Also, the current draft revisions will continue to be published until the blocks are updated. This should mean no change on the front end until the promo blocks are edited.

• As an admin, release content (take the dog for a walk, wash the car, make dinner for your extended family, or all of the above)
• Check the pages that you edited:
  • Prepare for VA’s secure sign-in changes
  • VA 1-on-1: Veteran Assistance Expo
• Check the mega nav promo block to confirm that the front end is only showing the default revision

Regression tests

• Cypress: landing_page.feature
  • This covers the creation of a node that uses the Promo block.
• Cypress: clp_basic_requirements.feature
  • This covers the creation of a node that both uses the Promo block and the Entity Browser Table widget that we have patched.

If these are still working, then the changes did not cause a regression.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[dsasser]

Code changes look good, I just had a few non-blocking comments.

[github-actions]

Checking composer.lock changes...

[github-actions]

The number of lines changed in composer.lock exceeds the acceptable threshold.

• Lines changed: 611
• Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

[laflannery]

Notes:

• I needed to create my own Google sheet because I didn't have access to edit the one linked in the description so mine with notes/results is here
  • The nodes are different than the original sheet to help make FE testing easier
  • I added the expected FE link and the expected FE results to again hopefully make FE testing just a click and check situation
• The FE testing also still needs to be done, because it didn't build. I while I know that there are some QA steps above, I have some more details ones here that would be good:
  • Go to the Education Benefits Hub Landing Page
    • Confirm that the GI Bill promo in the right rail does NOT say DRAFT in the title link text
  • In the header main navigation, open the Education mega nav
    • Confirm that the GI Bill promo in the right column does NOT say DRAFT in the title link text
  • Go to the Health Care Hub Landing Page
    • Confirm that the PACT Act promo in the right rail does say PUB in the title link text
  • In the header main navigation, open the Health Care mega nav
    • Confirm that the Health Care promo in the right column does say PUB in the title link text

[github-actions]

Checking composer.lock changes...

[github-actions]

The number of lines changed in composer.lock exceeds the acceptable threshold.

• Lines changed: 611
• Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

[github-actions]

Checking composer.lock changes...

[github-actions]

The number of lines changed in composer.lock exceeds the acceptable threshold.

• Lines changed: 591
• Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

[github-actions]

Checking composer.lock changes...

[github-actions]

The number of lines changed in composer.lock exceeds the acceptable threshold.

• Lines changed: 591
• Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

[va-cms-bot]

Cypress Accessibility Violations

/test-data-alias

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"

[jilladams]

#19551 (comment)

FE testing is good. @omahane FYI