-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VATEAM-90628: Add Identification Information Paragraph type #19190
Merged
ryguyk
merged 4 commits into
integration-form-engine-2
from
90628-identification-information-pattern
Sep 17, 2024
Merged
VATEAM-90628: Add Identification Information Paragraph type #19190
ryguyk
merged 4 commits into
integration-form-engine-2
from
90628-identification-information-pattern
Sep 17, 2024
+434
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CMS Team
CMS Product team that manages both editor exp and devops
label
Sep 11, 2024
ryguyk
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
ryguyk
force-pushed
the
integration-form-engine-2
branch
from
September 16, 2024 16:13
e4cd6f2
to
892ca0c
Compare
ryguyk
force-pushed
the
90628-identification-information-pattern
branch
from
September 16, 2024 16:13
c4618f2
to
e07c5f7
Compare
10 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a Paragraph type in Drupal for the "Identification Information" pattern. (See the Social security or VA file number pattern for more details on the pattern.) The Paragraph type includes an "Include Veteran's Service Number?" boolean field. Adds the new Paragraph type to the list of available Paragraph types in the "Steps" field of the Digital Form content type.
Testing done
Screenshots
The "Identification Information" pattern as part of the "Add Step" modal:
An expanded "Identification Information" Paragraph inside the "Steps" field of a Digital Form:
QA steps
As an administrator
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?