Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VATEAM-90628: Add Identification Information Paragraph type #19190

Merged

Conversation

derekhouck
Copy link
Contributor

@derekhouck derekhouck commented Sep 11, 2024

Description

Creates a Paragraph type in Drupal for the "Identification Information" pattern. (See the Social security or VA file number pattern for more details on the pattern.) The Paragraph type includes an "Include Veteran's Service Number?" boolean field. Adds the new Paragraph type to the list of available Paragraph types in the "Steps" field of the Digital Form content type.

Testing done

  • Manually created a Digital Form with a Step that included the "Identification Information" Paragraph type.
  • Ran the updated script in my local environment and verified the creation of Digital Forms with the proper Steps.

Screenshots

The "Identification Information" pattern as part of the "Add Step" modal:
Screenshot 2024-09-11 at 2 16 54 PM

An expanded "Identification Information" Paragraph inside the "Steps" field of a Digital Form:
Screenshot 2024-09-11 at 2 17 57 PM

QA steps

As an administrator

  1. Go to Manage > Content > Add content > Digital Form
  2. In the "Steps" field, click "Add Step"
    • Verify "Identification Information" appears one of the patterns in the "Add Step" modal.
  3. Click "Add" underneath "Identification Information"
    • Verify the "Identification Information" Paragraph appears expanded in the "Steps" field.
    • Verify the "Title" field is required and has a default value of "Identification Information"
    • Verify a checkbox field is present labeled "Include Veteran's Service Number?"
  4. Select the "Include Veteran's Service Number?" checkbox
  5. Fill out the other required fields on the Digital Form and click "Save" at the bottom of the page.
    • Verify the Digital Form saves successfully.
    • Verify the "Identification Information" Paragraph is included in the "Steps" field of the view page.
    • Verify the "Include Veteran's Service Number?" field is set to "Yes"

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 11, 2024 19:09 Destroyed
@derekhouck derekhouck requested a review from ryguyk September 11, 2024 19:27
@derekhouck derekhouck marked this pull request as ready for review September 11, 2024 19:27
@derekhouck derekhouck requested review from a team as code owners September 11, 2024 19:27
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Sep 11, 2024
Copy link
Contributor

@ryguyk ryguyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@ryguyk ryguyk force-pushed the integration-form-engine-2 branch from e4cd6f2 to 892ca0c Compare September 16, 2024 16:13
@ryguyk ryguyk requested review from a team as code owners September 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants