Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14683: Integration Service Location PR Comment Fixes #18062

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented May 7, 2024

Description

Fixes PR change suggestions for the Service Location MVP integration branch. This PR reverts unwanted changes in composer.lock and .github/workflows/default-branch-datadog-metrics.yml.

Relates to #14683
Relates to integration branch PR 15622

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@dsasser dsasser requested a review from a team as a code owner May 7, 2024 17:20
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 7, 2024 17:20 Destroyed
Copy link

github-actions bot commented May 7, 2024

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@jilladams jilladams self-requested a review May 7, 2024 17:42
@dsasser dsasser merged commit bbc244b into integration-service-location May 7, 2024
16 of 17 checks passed
@dsasser dsasser deleted the VACMS-14683-integration-service-location-pr-fixes branch May 7, 2024 17:45
@omahane
Copy link
Contributor

omahane commented May 10, 2024

@dsasser Thanks for doing this. I wish I knew how those got in there. I've been bird-dogging some of those changes and thought I'd accounted for them. I appreciate the clean-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants