Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-9717 Make CMS the source of truth for VAMC mental health phone #15585

Merged
merged 6 commits into from
Jan 16, 2024
Merged

VACMS-9717 Make CMS the source of truth for VAMC mental health phone #15585

merged 6 commits into from
Jan 16, 2024

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 6, 2023 •
edited
Loading

Description

This is the PR of the integration branch. It can not be merged until LH is prepared to receive.

Relates to #9717 and merging is covered by #15576

This PR is set to merge on Tuesday Jan 16th in time for deploy on that day.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  • Testing of the field editability and removal from migration already tested on initial PR
  1. Then
    • Validate that
  2. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@swirtSJW swirtSJW added VAMC CMS managed product owned by Facilities team Facilities Facilities products (VAMC, Vet Center, etc) DO NOT MERGE Do not merge this PR Blocked Issues that are blocked on factors other than blocking issues. Awaiting Official Launch Code is approved and ready for merge, but needs a launch. labels Oct 6, 2023
@swirtSJW swirtSJW self-assigned this Oct 6, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 6, 2023 20:29 Destroyed
This was referenced Oct 6, 2023
Closed
Closed
@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from 2575fc3 to fe8fa5e Compare October 13, 2023 18:44
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 18:44 Destroyed
@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from fe8fa5e to 91ed556 Compare October 14, 2023 02:08
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 14, 2023 02:08 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 15, 2023 01:19 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2023 19:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2023 22:05 Destroyed
@swirtSJW
Copy link
Contributor Author

phone number example as been added.

@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from 5f04bc9 to 32f45be Compare October 31, 2023 16:14
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2023 16:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 6, 2023 14:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:27 Destroyed
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 1, 2023

Seed data was pushed from my local to LH prod on 12/1/2023

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 1, 2023

This commit was moved to its own PR
image
#16274

swirtSJW and others added 3 commits December 1, 2023 21:45
@swirtSJW
VACMS-14213 Make CMS the source of truth for VAMC mental health phone…
3e836e1 
… number (#15468)

* VACMS-14213 Move VAMC mental health number to editable region.

* VACMS-14213 Remove Mental health phone number from VACMS facility migration.

* VAMC-14213 Updated help text.

* VACMS-14213 Change phone field labels to title case.
@swirtSJW
VACMS-15647 Add new vamc mental health field. (#15679)
c1bb433 
* Revert "VACMS-14213 Make CMS the source of truth for VAMC mental health phone number (#15468)"

This reverts commit 2575fc3.
in order to restore the field location in the api data and its place in the migration.

* VACMS-15647 Add editable mental health contact field to VAMC facility
@swirtSJW
Add sample phone number.
04c1ca2
@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from 71f7aec to 04c1ca2 Compare December 2, 2023 02:46
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 2, 2023 02:46 Destroyed
@swirtSJW swirtSJW added refresh-tugboat-cache Used by GHA Tugboat automation and removed DO NOT MERGE Do not merge this PR Blocked Issues that are blocked on factors other than blocking issues. Awaiting Official Launch Code is approved and ready for merge, but needs a launch. labels Jan 16, 2024
@swirtSJW
Copy link
Contributor Author

Closing to toggle tugboat stuck

@swirtSJW swirtSJW closed this Jan 16, 2024
@swirtSJW
Copy link
Contributor Author

Opening to unstick tugboat

@swirtSJW swirtSJW reopened this Jan 16, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 15:29 Destroyed
@swirtSJW swirtSJW added the Lighthouse Facility API Data source/destination for many Facilities team products label Jan 16, 2024
@swirtSJW swirtSJW marked this pull request as ready for review January 16, 2024 15:31
@swirtSJW swirtSJW requested a review from a team as a code owner January 16, 2024 15:31
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 15:41 Destroyed
@swirtSJW
Copy link
Contributor Author

Closing again because now we have two tugboat instances.

@swirtSJW swirtSJW closed this Jan 16, 2024
@swirtSJW
Copy link
Contributor Author

Re-opening to jumpstart tugboat

@swirtSJW swirtSJW reopened this Jan 16, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 16:04 Destroyed
@swirtSJW
Copy link
Contributor Author

This was already fully QA's as things entered the integration branch, but just in case here was a quick runthrough of saving facility that had an existing MH number
image

and one that did not.
image

@swirtSJW
Copy link
Contributor Author

The failing cypress test is unrelated
image

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 17:02 Destroyed
@swirtSJW
Copy link
Contributor Author

Same failing cypress test. Investigating

@swirtSJW
Copy link
Contributor Author

The Cypress failure occurring on this PR is unrelated to Mental health numbers and is failing across multiple PRs.
It is being covered by this issue #16850

It should not hold up merging this, BUT it will prevent this from going out with today's deploy.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 17:51 Destroyed
@swirtSJW
Copy link
Contributor Author

I am merging this so that it will be ready to go out when the other issue is resolved.

@swirtSJW swirtSJW merged commit 51a8473 into main Jan 16, 2024
14 of 18 checks passed
@swirtSJW swirtSJW deleted the integration-mental-health-phone branch January 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@swirtSJW swirtSJW

Labels
Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products refresh-tugboat-cache Used by GHA Tugboat automation VAMC CMS managed product owned by Facilities team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swirtSJW @va-cms-bot