VACMS-11115: Add VA Form flag Views.

[chri5tia]

Description

Closes #11115 , #11118, #11117, #11116 (no github magic if you list them like this)
Closes #11118
Closes #11117
Closes #11116

Adds 3 new views to the VA Forms content administration area:

• Changed Filename
• Changed Title
• New and deleted forms

Testing done:

(Updated)

• Views bulk operation clears flags
• View shows flagged items according to link tab, page title and table caption
• Title/Name filter
• Moderation state filter
• Section filter
• Form administration filter shows (VACO, VBA, VHA, NCA, OCTO)
• Edit links
• Columns match style guide order
• Custom text and rewrite tokens work: updated by, locked by, edit button

Screenshots

QA steps

• New view should appear in VA Forms area: https://cms-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/admin/content/va-forms
• New view follows CMS Views style guide
• Display flags with columns
• • Title
• • Edit button
• • Content type
• • Updated (timestamp and author)
• • Moderation state
• • Section
• • Lock
• • Form administration
• Bulk action to clear flags on selected items and that the action matches the type of flags shown
• Requires PM/DM review
• Click on edit for one form on each tab, then go back (no need to save)
• Ensure that the form specifies that it is now locked in the lock column, for each tab
• Ensure that edited by shows author
• Check that all exposed filter views work

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.

Select Team for PR review

• Platform CMS Team
• Sitewide program
• ⭐️ Sitewide CMS
• ⭐️ Public websites
• ⭐️ Facilities
• ⭐️ User support

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing annoucement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[chri5tia]

Thanks for the feedback @dsasser on #11118. Applying it here first. I need this PR to deploy first because it has the patch for VBO and flags.

Content type filter is not necessary
Removed

Missing title/form name exposed filter per views style guide
Added

VBO checkbox is in the far right column; should be far left column
Fixed

Content type column is not necessary
Removed

We should probably follow the existing practice employed by Facilities, which is to add all related product views to the same View as individual displays. See /admin/structure/views/view/facility_services/edit/content_audit_facilities?destination=/admin/content/facilities

All the form views are different displays of the "flagged" view, because they are basic duplicates of that view with small alterations. I'd rather keep it here for now, since backend changes to this should all be in the same place.

Column order does not follow views style guide.
Fixed

Missing moderation state filter per views style guide
Added

[swirtSJW]

Noticed a couple of things

• updated is missing the user reference

• The edit button links are missing the node ids so the links don't function
  

• The locked column does not reflect that something is locked. Though to be honest, with how crowded the table it, we may want to consider abandoning the locked column in favor of readability
  

• The last "Changed Filename" view tab is actually a Deleted View.

  • The deleted should be included in the "New Form" View as that will surface the common issue of one being deleted and a duplicate created. I suggest changing the name of the View to "New/Deleted Forms"

• Tables need captions. (Please add captions to our style guide doc, I think it is missing.)
  

[jilladams]

In addition to Steve's note:

• For Flags and Lock columns, the Table header and table columns are swapped (wrong header appears on the column).
  • Flags column header should appear over Flags field
  • Lock header should appear over Lock field, unless we remove it altogether. (I'm ok with removing.)
• Can you add Form administration as a Filter on all 4 views?

#11118 https://pr11251-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/admin/content/va-forms/changed-title
#11115 https://pr11251-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/admin/content/va-forms/changed-filename
#11117 https://pr11251-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/admin/content/va-forms/new-form
#11116 https://pr11251-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/admin/content/va-forms/deleted-form

[chri5tia]

@swirtSJW @jilladams The above comments and concerns are fixed. I realized I broke some things when I rearranged columns for the style guide. Oops!

Edited PR body.

[swirtSJW]

@chri5tia This is looking really good. A couple things

• Lets not surface the field name in the filter. Filed names are only for us drupal geeks and don't have much value to others, and create more confusion.
  

• The pattern of the actions on the other Views use the pattern of resolved
  Where the new deleted breaks that pattern
  
  HOWEVER, I would also touch base quickly with @BlakeOrgan Since these are names for actions, I think they want to be phrased as an action, not a noun. Example: "Remove Deleted flag", "Remove Filename Changed flag"

• This one is scope creep so consult with @jilladams and @wesrowe but I think I recall Dave suggesting this AND it is super easy to add. I suggest removing the locked column and adding the revision log message to ALL the View displays. I think it makes these tools even more useful than they already are.
  

[chri5tia]

@swirtSJW machine name was an oversight, thank you! Regarding the other items:

• I will consult regarding replacing lock with the change log. Wondering if that might be a part two?
• Regarding the names of the items in the drop down, they were already called that and didn't want to change the name due to possibly being used in other places. I will consult but wondering if that would also be a good part two?

[dsasser]

@chri5tia @swirtSJW quick note on the lock field in the table: lock changes are not immediately visible in the View. To replicate:

• Find an unlocked node in the View
• Edit the node in a new tab
• Refresh the View
• Notice the lock column doesn't change for the affected node
• Perform a cache clear
• Refresh the View
• Notice the lock column is now correct

This may be expected/well known, but figured I would flag it up for visibility.

[swirtSJW]

Regarding lock, if we want to keep it, we should remove tag caching on the View. I don't think the lock state is worth keeping.

[swirtSJW]

@chri5tia I see what you mean about the actions. They are being pulled from the flag itself.

I think the wording of those should change, but does not have to be part of this issue. I am spinning up another ticket now to
#11285

[dsasser]

Yeah I would agree we don't need the lock column and by removing it we can retain Views caching.

[jilladams]

Re-verified on https://pr11251-gcjxrl4huhyj4lipesbplzfbyy2zsjcs.ci.cms.va.gov/:

• All 3 new tabs match page contents / flags
• Edit links working on all 3 views
• Filters working on all 3 views
• Flag actions on New / Deleted are updated
• Action to remove flag is working
• Column order is consistent across all 3 views
• Headers match table contents
• Lock column is removed
• Updated column shows username
• Revision log message shows on all 3
• Form admin filter doesn't show machine name
• New/deleted is showing table data

Only thing I don't know how to verify is that all 3 tables have captions added. (Could someone show me that?)

[swirtSJW]

Tests out good. Nice work.

I added a commit did a couple of barely noticeable things.

1. I removed the lock releated fields from the table as they were now all hidden.
2. I removed the label overrides so they they could be controlled by the content on the flag, rather than config in the override on the view. ALso it is a separate ticket needing design input Reword VA Form flag "Unflag link text" to describe the action. #11285
3. Rearranged the filters to move moderation state left of section. Section and admin are somewhat paired so it makes sense to have them paired visually.

[swirtSJW]

I think the php unit test is a fluke.

I am running it again

[chri5tia]

Yeah, it has to do with the database save point failing and using a previous save point. I don't think we need to worry about that.

1) tests\phpunit\Content\NodeLinkEnforcementFilterTest::testProcess with data set #5 ('<a href="node/230947230952309...st</a>')
Drupal\Core\Entity\EntityStorageException: SQLSTATE[42000]: Syntax error or access violation: 1305 SAVEPOINT savepoint_1 does not exist: ROLLBACK TO SAVEPOINT savepoint_1; Array
(
)