Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service locations render in confusing ways when no name is provided. #7416

Closed
ryguyk opened this issue Dec 28, 2021 · 3 comments
Closed

Service locations render in confusing ways when no name is provided. #7416

ryguyk opened this issue Dec 28, 2021 · 3 comments
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@ryguyk
Copy link
Contributor

ryguyk commented Dec 28, 2021

Description

Service locations (for both health services and non-clinical services) render in interesting ways when no name is provided, particularly when multiple service locations exist at a single facility.

Here is an example from production (as it stands currently) with multiple service locations at a single facility:
image

And, with annotations:
image

Here is the same data as it will appear with the new logic for displaying service location address (or, in this case, not displaying service location address when "use facility address" box is checked. see #7339):
image

Acceptance Criteria

On the front end, there should likely be some default header in the case when no name is provided for a service location. This would have two major outcomes:

  1. Would provide visual separation for a service location (so information like hours don't appear to be a continuation of a previous location).
  2. Would dictate that all headers (e.g. "Hours") are the same header level (i.e. h5) for all locations.

It was first discussed whether this name field should be required in the CMS, but this feels less than desirable in the scenario where there is only one service location at a given facility, and this scenario seems like it's the rule more than the exception. This led to the idea that a FE default might be a good solution, at least temporarily. It would be temporary if it is decided that the best solution is some extended CMS logic that would potentially require names for service locations if, for example, multiple locations exist. It would otherwise be permanent.

https://dsva.slack.com/archives/CT4GZBM8F/p1640632587107500?thread_ts=1640631116.105000&cid=CT4GZBM8F

@ryguyk ryguyk added the Needs refining Issue status label Dec 28, 2021
@mmiddaugh
Copy link
Contributor

@davidmpickett davidmpickett added the Facilities Facilities products (VAMC, Vet Center, etc) label Mar 11, 2024
@xiongjaneg xiongjaneg added VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Drupal engineering CMS team practice area Regional office CMS managed VBA product owned by the Facilities team labels Mar 19, 2024
@xiongjaneg
Copy link
Contributor

@davidmpickett To review for current state and what elements of this no longer apply

@davidmpickett davidmpickett self-assigned this Apr 10, 2024
@davidmpickett davidmpickett closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
@davidmpickett davidmpickett removed their assignment Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants