Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider: Conditionally require field_clinic_name on Service Location Address #17380

Open
1 of 9 tasks
davidmpickett opened this issue Feb 28, 2024 · 1 comment
Open
1 of 9 tasks
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Feb 28, 2024

User Story or Problem Statement

As a Facilities team member, I want to prevent Editors from entering information that will result in skipped headings. While there may be ways to make the Front End defensive against these scenarios, making a requirement at the Drupal level could be more impactful long-term

As a consumer of the Facilities API, I need a unique ID to differentiate Service Locations when there are more than 1 on a Service

Desired logic:
IF either field_building_name_number or field_wing_floor_or_room_number are populated
THEN field_clinic_name should be required

ALSO

IF there are two or more Service Locations on a Service
THEN field_clinic_name should be required
AND Should be different that other Service Locations on the Service

Possible wrinkle:
Service Location Address is nested in Service Location which is nested in four different Facility Services. Can this logic live at the Paragraph level, or does it need to be added to every Content Type that uses the Paragraph?

flowchart TD
  paragraphservice_location{{"Service location<br>paragraph"}}
click paragraphservice_location "/admin/reports/content-model/entity-diagram/paragraph/service_location"
  paragraphservice_location_address{{"Service location address<br>paragraph"}}
  paragraphservice_location -->|"address"|paragraphservice_location_address
  nodehealth_care_local_health_service(("VAMC Facility Health Service<br>node"))
click nodehealth_care_local_health_service "/admin/reports/content-model/entity-diagram/node/health_care_local_health_service"
  nodehealth_care_local_health_service -->|"service_location"|paragraphservice_location
  nodeservice_region(("Service Region<br>node"))
click nodeservice_region "/admin/reports/content-model/entity-diagram/node/service_region"
  nodeservice_region -->|"service_location"|paragraphservice_location
  nodevba_facility_service(("VBA Facility Service<br>node"))
click nodevba_facility_service "/admin/reports/content-model/entity-diagram/node/vba_facility_service"
  nodevba_facility_service -->|"service_location"|paragraphservice_location
  nodevha_facility_nonclinical_service(("VAMC Facility Non-clinical Service<br>node"))
click nodevha_facility_nonclinical_service "/admin/reports/content-model/entity-diagram/node/vha_facility_nonclinical_service"
  nodevha_facility_nonclinical_service -->|"service_location"|paragraphservice_location
style paragraphservice_location_address fill:#ffaacc,stroke:#333,stroke-width:4px;
Loading

Description or Additional Context

VAMC Service locations_2024-02-28_23-56-22

Steps for Implementation

Acceptance Criteria

  • Testable_Outcome_X
  • Testable_Outcome_Y
  • Testable_Outcome_Z
  • Requires design review
  • Requires accessibility review

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@davidmpickett davidmpickett added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices labels Feb 28, 2024
@davidmpickett davidmpickett changed the title [CONSIDER] Conditionally require field_clinic_name on Service Location Address [Consider] Conditionally require field_clinic_name on Service Location Address Mar 5, 2024
@davidmpickett
Copy link
Contributor Author

@xiongjaneg - this one isn't a huge priority, but might be good to take to a Drupal Pre-refinement soon as a compliment to #17414

@davidmpickett davidmpickett changed the title [Consider] Conditionally require field_clinic_name on Service Location Address Consider: Conditionally require field_clinic_name on Service Location Address Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices
Projects
None yet
Development

No branches or pull requests

2 participants