-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics] [VAMC link teasers] Custom GA events removal #18501
Comments
Closing. |
Whoops - I somehow flubbed the code link for this. It should be pointing here: https://github.com/department-of-veterans-affairs/content-build/blob/main/src/site/paragraphs/facilities/list_of_link_teasers_facility.drupal.liquid#L49 (also updated in the ticket description). Reopening; but please flag if this was somehow solved another way. |
@randimays This one has disable-analytics and some paragraph-related data being captured. Are we sure we are ok losing that? I mean, I'm guessing it's probably fine because we get textual data on link clicks from DST component analytics. |
@eselkin Tagging in @Agile6MSkinner for this; that is a Product decision but Product was largely deferring to me to make decisions about when to remove analytics so I made the ticket for our consideration. |
I don't know enough about our analytics yet to answer. @mmiddaugh do you have thoughts on Eli's question above? |
This is extent of what we get from the "extra" data:
It's like a little broader than what comes back from the regular DST component data. The link title would still come back, but the fieldTitle on the featured content would not normally. Let me do a local build with analytics allowed and copy the 2 objects side by side |
This is at: https://www.va.gov/pittsburgh-health-care/#9246d10cf4f5f599e892c702e4ffe33a In the annotated image below, only the custom event currently triggers. If we replace it with the DST event we lose that paragraph.fieldTitle ("In the spotlight at VA Pittsburgh...") However, that title seems wrong since you would expect it to be: "Other services at VA Pittsburgh health care" or something closer, but it's the section. I'm all for removing the custom event since the additional information is kind of not clarifying. |
@FranECross since you've been closer to this project, you can maybe help Michael co-sign Eli's note? |
|
Discussed at product sync. Per @mmiddaugh and team, keep the custom tagging because it provides higher fidelity. Disable DST. This conversation uncovers a broader need to work with DST on the tagging in components and the utility of the analytics that are provided. |
@eselkin Looking at this one to verify if it's closeable, but I think it needs follow up. Fran had originally co-signed removing the custom event, which went into a PR. But a follow up comment suggested instead keeping the custom event / removing the DST event instead. I think that still needs PR. I'm gonna move this ticket back to Current sprint to catch that change. |
However the custom event was incorrect in its data |
Ah, I think we missed that in the discussion with michelle. noting for next scrum (Thurs), just to make sure no other danglers and we can close as is. |
@eselkin looking at this in hopes of getting closure, 2 questions:
|
I think #2 above is what Michelle would want, since in the prod sync meeting she indicated she relies on the 'Featured content header' in order to gather meaningful analytics, so fixing the header text would do what she needs, as well as disabling the component analytics. |
I'm sure we can get that correct text and use the custom event. |
Status
Description
The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics for link teasers on VAMC pages.
User story
AS A PO/PM managing Sitewide products & features
I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events
SO THAT extraneous code is removed and only the events needed will be triggered.
Engineering notes / background
Content-build template: https://github.com/department-of-veterans-affairs/content-build/blob/main/src/site/paragraphs/facilities/list_of_link_teasers_facility.drupal.liquid#L49
Acceptance criteria
The text was updated successfully, but these errors were encountered: