Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy filter that causes undesired double spacing #16232

Closed
1 of 5 tasks
Tracked by #15479
tonytaylor opened this issue Nov 28, 2023 · 1 comment
Closed
1 of 5 tasks
Tracked by #15479

Remove legacy filter that causes undesired double spacing #16232

tonytaylor opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops

Comments

@tonytaylor
Copy link
Contributor

tonytaylor commented Nov 28, 2023

Description

This is a follow-up to #13550.

We found that there are multiple filters (Limit allowed HTML tags and correct faulty HTML & Correct faulty and chopped off HTML) that appear to put break tags into a state where they fail a check to not add an extra break tag. This issue may be resolved by patching the rule that seeks out the break tags to match them in their post-processed state.

Acceptance Criteria

  • Content in the Rich Text Limited editor does not create break <br> tags where there's a <br> + \n (Return)

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@tonytaylor tonytaylor added Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops labels Nov 28, 2023
@tonytaylor tonytaylor self-assigned this Nov 28, 2023
@tonytaylor
Copy link
Contributor Author

Update

TL;DR - This issue is caused by a 5-year old patch addressing a separate issue. Removal of the patch should resolve this matter.

I was vetting this issue out on a vanilla D10 install and could not replicate the problem. I soon found that our code is doing something different than that of core and recently ran it by @ndouglas. He quickly identified that we're already patching that code to address a separate issue improper new line/carriage return conversion, which was addressed last year with Html::transformRootRelativeUrlsToAbsolute() replaces "\r\n" with " \n". Currently testing our D10 candidate build without the patch and all appears well. cc: @BerniXiongA6 @maortiz-27-80 @EWashb

@tonytaylor tonytaylor changed the title Update filter module to suppress undesired double spacing Remove legacy filter that causes undesired double spacing Nov 29, 2023
@BerniXiongA6 BerniXiongA6 removed the Needs refining Issue status label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

No branches or pull requests

2 participants