Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Preliminary work for SiteImprove test installations. #16207

Closed
4 tasks
ndouglas opened this issue Nov 27, 2023 · 9 comments
Closed
4 tasks

[SPIKE] Preliminary work for SiteImprove test installations. #16207

ndouglas opened this issue Nov 27, 2023 · 9 comments
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area Drupal engineering CMS team practice area

Comments

@ndouglas
Copy link
Contributor

Description

Followup from #15923 .

Basically, we need to install the SiteImprove module and determine whether it has any issues preventing it from being deployed or tested in Tugboat, Test-Staging, or local environments.

Tasks

  • Install and enable module in a feature branch.
  • Determine whether any issues have occurred already, and if so, fix them.
  • Open a PR in draft to have a reviewable Tugboat preview.
  • Push branch to va.gov-cms-test and deploy to test.staging.
  • Determine whether any issues have occurred already, and if so, fix them.

Acceptance Criteria

  • Module has been installed.
  • Scaffolding has been added to bring in API key, etc from appropriate source in given environment.
  • Any blocking issues have been resolved or inability to resolve them has been reported to Berni/Marcia/Erika.
  • Followup issue(s) opened for December 4 runbook/communications if no blocking issues found.
@ndouglas ndouglas added the Needs refining Issue status label Nov 27, 2023
@ndouglas ndouglas added DevOps CMS team practice area Drupal engineering CMS team practice area CMS Team CMS Product team that manages both editor exp and devops labels Nov 27, 2023
@ndouglas
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @edmund-dunn @JunTaoLuo @tonytaylor

@BerniXiongA6
Copy link

Still waiting for VHA DM to hear back from Siteimprove folx to get token -- we're blocked until Blake Scates gets that token and other info. cc: @maortiz-27-80 @ndouglas

@ariperez ariperez self-assigned this Dec 7, 2023
@maortiz-27-80
Copy link

@ariperez - are you able to point this ticket, assuming that we have the token? we're still waiting on VHA-DM team for the token and will provide that asap. cc: @ndouglas @BerniXiongA6 @JunTaoLuo

@BerniXiongA6
Copy link

Updates from Siteimprove 12.8.2023: @BerniXiongA6 has forwarded guidance and instructions from Siteimprove to @ariperez @JunTaoLuo @ndouglas on how to get the Plugin properly installed in order to get Prepublish configured properly (looks like a process for requesting a new token is included in the guidance). cc: @maortiz-27-80 @EWashb

@maortiz-27-80
Copy link

@ariperez - Before you get too into the weeds of this ticket, at your earliest convenience, can you confirm the following so we can follow up with VHA-DM and Siteimprove if we need additional assistance:

  1. Siteimprove token (for the Siteimprove plugin) works correctly (if token field is empty)
  2. Siteimprove API username and API key work correctly for setting up the prepublish check

cc: @BerniXiongA6 @ndouglas @JunTaoLuo @EWashb

@maortiz-27-80
Copy link

@EWashb - The team is stuck on getting the API username and API keys to configure the plugin on http://test.prod.cms.va.gov/admin/config/system/siteimprove

With Laura's existing Siteimprove credentials (one for Va.gov and one for Civic Actions), we were unable to generate an API username and API key with the instructions that were included here.

siteimprove_plugin_01 - plugin displays (floating)
siteimprove_plugin_01.png

siteimprove_plugin_02 - plugin displays unavailable message when clicked on
siteimprove_plugin_02.png

siteimprove_config - config page where we are unable to generate and fill in: (1) API username and (2) API key
siteimprove_config.png

cc: @BerniXiongA6 @ndouglas @ariperez @laflannery @JunTaoLuo

@maortiz-27-80
Copy link

@ariperez - VHA-DM has provided username and API key. let me know if this works:

User Name: Laura Flannery

Key: 5963c49ba007c022f19f029f3b789397

cc: @BerniXiongA6 @EWashb @ndouglas @laflannery @JunTaoLuo

@ariperez
Copy link
Contributor

@maortiz-27-80 , we tried multiple variations of user name for Laura, still no luck.

image.png

also, noting that in the SI ui, Laura still cannot access API config functionality, which seems like it should be possible in order for her to manage her API keys...image.png

https://www.drupal.org/node/3180424

@maortiz-27-80
Copy link

Per slack convo here, 12/14, this ticket is complete and marking as Closed. Separate ticket, #10275 will be utilized for implementing the API username and API key and initiating deep linking with SI. cc: @ariperez @BerniXiongA6 @ndouglas @JunTaoLuo @laflannery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area Drupal engineering CMS team practice area
Projects
None yet
5 participants